Обсуждение: Re: [Pgweb] r2149 - in trunk/archives/html: . includes

What's the reason for this? :-) Keeping it on the main website gets you the global distribution for faster access, and also better caching for people... Is there any reason not to use that? //Magnus pgweb@pgweb.postgresql.org wrote: > Author: alvherre > Date: 2008-06-30 06:19:50 -0700 (Mon, 30 Jun 2008) > New Revision: 2149 > > Modified: > trunk/archives/html/ > trunk/archives/html/includes/top_config.php > Log: > Use a svn:external property to have the layout files in place instead of > referring to www.postgresql.org. > > > > Property changes on: trunk/archives/html > ___________________________________________________________________ > Name: svn:externals > + layout/css https://pgweb.postgresql.org/svn/trunk/portal/layout/css > layout/js https://pgweb.postgresql.org/svn/trunk/portal/layout/js > layout/images https://pgweb.postgresql.org/svn/trunk/portal/layout/images > > > > Modified: trunk/archives/html/includes/top_config.php > =================================================================== > --- trunk/archives/html/includes/top_config.php 2008-06-30 11:56:31 UTC (rev 2148) > +++ trunk/archives/html/includes/top_config.php 2008-06-30 13:19:50 UTC (rev 2149) > @@ -1,9 +1,10 @@ > + > > > - @import url("http://www.postgresql.org/layout/css/blue/fixed.css"); > - > - > - > + @import url("/layout/css/blue/fixed.css"); > + > + > + > > > > @@ -39,20 +40,20 @@ >

>

Header And Logo

>

> - > + >

>

> | > - > + >

>

>

Site Navigation

>

>

> - > + >

>

> - > + >

>

>
• > > _______________________________________________ > Pgweb mailing list > Pgweb@pgweb.postgresql.org > http://community1.commandprompt.com/cgi-bin/mailman/listinfo/pgweb

Magnus Hagander wrote:
> What's the reason for this? :-)
> 
> Keeping it on the main website gets you the global distribution for
> faster access, and also better caching for people... Is there any reason
> not to use that?

Yes -- one of the .css files references another one by relative path, so
it gets a 404 when loaded from archives.

I guess another solution would be to fix all the relative paths in
there.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Magnus Hagander wrote:
> What's the reason for this? :-)
> 
> Keeping it on the main website gets you the global distribution for
> faster access, and also better caching for people... Is there any reason
> not to use that?

Also, in order to fix the hardcodedness of lists in the archives pages, 
I need a templating system; and what better idea than to just reuse the
PgPage stuff?  So I was considering using svn:externals to get
portal/system/global and pearlib/ into trunk/archives, so that a
checkout of archives gets the needed files.

The downside is that if somebody checks out pgweb:trunk/ then he will
get those files twice.  Is that too much of a problem for anyone?


(Before anybody complains about the extra load, I'm not planning to use
the templating stuff for every page load -- only to generate some
includes when the list of lists changes.  This probably means that it
will be cheaper than the current code, because most of it will be plain
HTML instead of having some embedded PHP.)

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera wrote:
> Magnus Hagander wrote:
>> What's the reason for this? :-)
>>
>> Keeping it on the main website gets you the global distribution for
>> faster access, and also better caching for people... Is there any reason
>> not to use that?
> 
> Also, in order to fix the hardcodedness of lists in the archives pages, 
> I need a templating system; and what better idea than to just reuse the
> PgPage stuff?  So I was considering using svn:externals to get
> portal/system/global and pearlib/ into trunk/archives, so that a
> checkout of archives gets the needed files.

Ah, so there's an ulterior motive :-)


> The downside is that if somebody checks out pgweb:trunk/ then he will
> get those files twice.  Is that too much of a problem for anyone?

Shouldn't be, they're tiny.


> (Before anybody complains about the extra load, I'm not planning to use
> the templating stuff for every page load -- only to generate some
> includes when the list of lists changes.  This probably means that it
> will be cheaper than the current code, because most of it will be plain
> HTML instead of having some embedded PHP.)

Check. I absoluteliy don't mind getting it folded into using the
standard stuff.

//Magnus

Alvaro Herrera wrote:
> Magnus Hagander wrote:
>> What's the reason for this? :-)
>>
>> Keeping it on the main website gets you the global distribution for
>> faster access, and also better caching for people... Is there any reason
>> not to use that?
> 
> Yes -- one of the .css files references another one by relative path, so
> it gets a 404 when loaded from archives.

Hmm. Yuck. That does make sense though :-)


> I guess another solution would be to fix all the relative paths in
> there.

Probably not a bad idea, to at least retain the ability. Care to submit
a patch? ;)

//Magnus