Обсуждение: Docs build-depends missing from PostgreSQL spec file
Hi
--
During some unrelated testing I noticed that the build-deps for the docs are missing from the PostgreSQL spec files.
The following entries should be added to ensure that the docs can be built reliably:
BuildRequires: openjade
BuildRequires: opensp
BuildRequires: docbook-dtds
BuildRequires: docbook-style-dsssl
BuildRequires: libxslt
On Thu, 2015-04-09 at 13:36 +0800, Craig Ringer wrote: > During some unrelated testing I noticed that the build-deps for the > docs are missing from the PostgreSQL spec files. > > > The following entries should be added to ensure that the docs can be > built reliably: > > > BuildRequires: openjade > > BuildRequires: opensp > BuildRequires: docbook-dtds > BuildRequires: docbook-style-dsssl > BuildRequires: libxslt Dear Craig, We are using ./generate-pdf.sh instead of spec file. I was asking on the same question some time ago. I was told that this is intentional. It is quite burden cpu time to build it with every single commit. Additionally, we run rpmbuild on multiple architectures. The generate-pdf part takes about same time as rest of build on my desktop. The pdf is more less text document so we are considering to be not against the compile everything from source code policy. There is an bug report on that. https://bugzilla.redhat.com/show_bug.cgi?id=1193693 regards, -- Jozef Mlich <jmlich@redhat.com> Associate Software Engineer - EMEA ENG Developer Experience Mobile: +420 604 217 719 http://cz.redhat.com/ Red Hat, Inc.
On 13 April 2015 at 15:40, Jozef Mlich <jmlich@redhat.com> wrote:
On Thu, 2015-04-09 at 13:36 +0800, Craig Ringer wrote:
> During some unrelated testing I noticed that the build-deps for the
> docs are missing from the PostgreSQL spec files.
>
>
> The following entries should be added to ensure that the docs can be
> built reliably:
>
>
> BuildRequires: openjade
>
> BuildRequires: opensp
> BuildRequires: docbook-dtds
> BuildRequires: docbook-style-dsssl
> BuildRequires: libxslt
Dear Craig,
We are using ./generate-pdf.sh instead of spec file.
These BuildRequires are necessary for the man pages and HTML docs, not just the PDF.
They should be present, at least if the doc subpackage is enabled. There's nothing wrong with putting them inside a conditional section that only gets evaluated if the docs are being built, of course.
Hi, On Thu, 2015-04-09 at 13:36 +0800, Craig Ringer wrote: > During some unrelated testing I noticed that the build-deps for the > docs are missing from the PostgreSQL spec files. > > The following entries should be added to ensure that the docs can be > built reliably: > > BuildRequires: openjade > BuildRequires: opensp > BuildRequires: docbook-dtds > BuildRequires: docbook-style-dsssl > BuildRequires: libxslt Thank you! Committed to git. They will appear in next update set. Regards, -- Devrim GÜNDÜZ Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer Twitter: @DevrimGunduz , @DevrimGunduzTR