Обсуждение: postgresql94-devel should Requires: libpam-devel etc

Hi folks

I've noticed another dependency issue that should probably be fixed for
the 9.4 package release.

The 9.4 spec BuildRequires: readline-devel and various other packages.
These are not depended on as Requires: by postgresql94-devel, but some
of them are assumed to by present by the Pg headers, and others are
referenced by linker options emitted by pg_config .

So postgresql94-devel should Requires these packages that are already
BuildRequires for the package as a whole.

Requires:  readline-devel
Requires:  zlib-devel >= 1.0.4
%if %ssl
Requires:  openssl-devel
%endif
%if %nls
Requires:  gettext >= 0.10.35
%endif
%if %xml
Requires:  libxml2-devel libxslt-devel
%endif
%if %pam
Requires:  pam-devel
%endif


I'm don't think the Kerberos, LDAP or SELinux libs are exposed by
pg_config, so they don't need to be dependencies.

I'll add them in the next rev of my unified package spec.
--
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Hi Craig,

Well, lazy me: pam-devel already requires pam, and given that I am
testing these in build machines, I did not notice these already.

That said, I was expecting RPM to pick up these automagically...

Regards, Devrim

On Mon, 2014-12-01 at 13:44 +0800, Craig Ringer wrote:
> Hi folks
>
> I've noticed another dependency issue that should probably be fixed for
> the 9.4 package release.
>
> The 9.4 spec BuildRequires: readline-devel and various other packages.
> These are not depended on as Requires: by postgresql94-devel, but some
> of them are assumed to by present by the Pg headers, and others are
> referenced by linker options emitted by pg_config .
>
> So postgresql94-devel should Requires these packages that are already
> BuildRequires for the package as a whole.
>
> Requires:  readline-devel
> Requires:  zlib-devel >= 1.0.4
> %if %ssl
> Requires:  openssl-devel
> %endif
> %if %nls
> Requires:  gettext >= 0.10.35
> %endif
> %if %xml
> Requires:  libxml2-devel libxslt-devel
> %endif
> %if %pam
> Requires:  pam-devel
> %endif
>
>
> I'm don't think the Kerberos, LDAP or SELinux libs are exposed by
> pg_config, so they don't need to be dependencies.
>
> I'll add them in the next rev of my unified package spec.
> --
>  Craig Ringer                   http://www.2ndQuadrant.com/
>  PostgreSQL Development, 24x7 Support, Training & Services
>
>


--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR