Обсуждение: Fwd: Bug #32904: pg_get_notify() ignores result_type param.

Поиск
Список
Период
Сортировка

Fwd: Bug #32904: pg_get_notify() ignores result_type param.

От
Volkan YAZICI
Дата:
From: PHP Bug Database <php-bugs@lists.php.net>
Date: May 1, 2005 3:50 PM
Subject: Bug #32904: pg_get_notify() ignores result_type param.
To: volkan.yazici@gmail.com


From:             volkan dot yazici at gmail dot com
Operating system: Debian GNU/Linux 3.0 (Unstable)
PHP version:      5.0.3
PHP Bug Type:     PostgreSQL related
Bug description:  pg_get_notify() ignores result_type param.

Description:
------------
Second parameter (result_type) used in pg_get_notify() is ignored. When we
look at ext/pgsql/pgsql.c (in revision 1.324, Wed Apr 13 18:11:35 2005 from
CVS):

  Line   49: #define PGSQL_ASSOC 1<<0
  Line   50: #define PGSQL_NUM 1<<1
  Line   51: #define PGSQL_BOTH (PGSQL_ASSOC|PGSQL_NUM)
  ...
  Line 4144: if (result_type & (PGSQL_NUM|PGSQL_BOTH)) {
  ...
  Line 4178: if (result_type & (PGSQL_ASSOC|PGSQL_BOTH)) {

Both of the if conditions in the lines 4144 and 4178 returns true
(positive values) on any input. Thus, result_type param. always acts as
PGSQL_BOTH.

Line 4144 and 4178 may be replaced by below ones:

  Line 4144: if (result_type & PGSQL_NUM) {
  ...
  Line 4178: if (result_type & PGSQL_ASSOC) {

They're working well on my current system.

Reproduce code:
---------------
/*
 * Any of these calls act as
 * var_dump(pg_get_notify($dbconn, PGSQL_BOTH));
 */
var_dump(pg_get_notify($dbconn));
var_dump(pg_get_notify($dbconn, PGSQL_NUM));
var_dump(pg_get_notify($dbconn, PGSQL_ASSOC));

Expected result:
----------------
array(4) {
  ["message"]=>
  string(1) "test"
  ["pid"]=>
  int(2317)
}
array(4) {
  [0]=>
  string(1) "test"
  [1]=>
  int(2317)
}
array(4) {
  ["message"]=>
  string(1) "test"
  ["pid"]=>
  int(2317)
}

Actual result:
--------------
array(4) {
  [0]=>
  string(1) "test"
  [1]=>
  int(2317)
  ["message"]=>
  string(1) "test"
  ["pid"]=>
  int(2317)
}
array(4) {
  [0]=>
  string(1) "test"
  [1]=>
  int(2317)
  ["message"]=>
  string(1) "test"
  ["pid"]=>
  int(2317)
}
array(4) {
  [0]=>
  string(1) "test"
  [1]=>
  int(2317)
  ["message"]=>
  string(1) "test"
  ["pid"]=>
  int(2317)
}