Обсуждение: Re: [pgsql-hackers-win32] pg_autovacuum fails to start - 8.0 Release

> -----Original Message-----
> From: pgsql-patches-owner@postgresql.org
> [mailto:pgsql-patches-owner@postgresql.org] On Behalf Of Dave Page
> Sent: 20 January 2005 15:29
> To: Harald Massa; pgsql-hackers-win32@postgresql.org
> Cc: Patches (PostgreSQL)
> Subject: Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum
> fails to start - 8.0 Release
>
> It appears I didn't read the docs properly when I write that
> bit - the dependencies parameter passed to CreateService() is
> supposed to be double-null terminated - a subtle point I missed :-(
>
> The attached patch fixes this. Harald - I can email an
> updated .exe if you want to test, otherwise, you should be
> able to use the current version if you cleanup the
> HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\pg_autova
> cuum\DependOnService registry key.

Sorry - the attached patch supercedes the original. It also directs
errors when installing/removing the windows service to stderr, rather
than other logs.

Regards, Dave.

Dave,

> [access denied]
>
> I see that message if the service user cannot access the executable - in
> my case, when I tried running it from my development directory, which
> the service user has no access to. When I moved the file to C:\Program
> Files\PostgreSQL\8.0\bin, it worked perfectly.
>

Hm. I put it there, too. But I copied it from the desktop (where I
downloaded and unzipped it)

And... checking the security-setting, it is exactly what your message
suggests: postgres does not have reading rights.

> It reports the failure in the logfile which becomes the log target. In
> the attached version, I've redirected all install/remove errors to
> stderr (and removed the debug print).

I think that is a good idea; not that "redirecting to log" would be wrong,
but it bytes. (Same problem with some applications of myself :))

Will try your patched patch,

thanks agaim,

Harald

[ Old version superceeded.]


Your patch has been added to the PostgreSQL unapplied patches list at:

    http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Dave Page wrote:
>
>
> > -----Original Message-----
> > From: pgsql-patches-owner@postgresql.org
> > [mailto:pgsql-patches-owner@postgresql.org] On Behalf Of Dave Page
> > Sent: 20 January 2005 15:29
> > To: Harald Massa; pgsql-hackers-win32@postgresql.org
> > Cc: Patches (PostgreSQL)
> > Subject: Re: [PATCHES] [pgsql-hackers-win32] pg_autovacuum
> > fails to start - 8.0 Release
> >
> > It appears I didn't read the docs properly when I write that
> > bit - the dependencies parameter passed to CreateService() is
> > supposed to be double-null terminated - a subtle point I missed :-(
> >
> > The attached patch fixes this. Harald - I can email an
> > updated .exe if you want to test, otherwise, you should be
> > able to use the current version if you cleanup the
> > HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\pg_autova
> > cuum\DependOnService registry key.
>
> Sorry - the attached patch supercedes the original. It also directs
> errors when installing/removing the windows service to stderr, rather
> than other logs.
>
> Regards, Dave.

Content-Description: pg_autovacuum.c.diff

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
>       joining column's datatypes do not match

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073