Обсуждение: Minor build fix for CVS HEAD

Поиск
Список
Период
Сортировка

Minor build fix for CVS HEAD

От
John Gray
Дата:
I'm quite fond of doing VPATH builds, i.e. building outside the source
tree. This also catches lots of little Makefile bugs, so here's a small
patch for one of them (replacing an explicit reference to thread.c with
a reference to it as the first prerequsite of the rule makes make look
for it in the place where it was found (the source tree) rather than in
the build tree. (using GNU make 3.79.1)
Regards

John (on holiday for two weeks so unlikely to be able to comment further
on it)


Index: src/port/Makefile
===================================================================
RCS file: /projects/cvsroot/pgsql-server/src/port/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- src/port/Makefile   8 Aug 2003 02:55:08 -0000       1.5
+++ src/port/Makefile   9 Aug 2003 19:42:53 -0000
@@ -23,7 +23,7 @@
        $(AR) crs $@ $^

 thread.o: thread.c
-       $(CC) $(CFLAGS) $(CPPFLAGS) $(THREAD_CFLAGS) -c thread.c
+       $(CC) $(CFLAGS) $(CPPFLAGS) $(THREAD_CFLAGS) -c $<

 clean distclean maintainer-clean:
        rm -f libpgport.a $(LIBOBJS)

--
John Gray <jgray@azuli.co.uk>
Azuli IT


Re: Minor build fix for CVS HEAD

От
Bruce Momjian
Дата:
Thanks.  Change made.

---------------------------------------------------------------------------

John Gray wrote:
> I'm quite fond of doing VPATH builds, i.e. building outside the source
> tree. This also catches lots of little Makefile bugs, so here's a small
> patch for one of them (replacing an explicit reference to thread.c with
> a reference to it as the first prerequsite of the rule makes make look
> for it in the place where it was found (the source tree) rather than in
> the build tree. (using GNU make 3.79.1)
> Regards
>
> John (on holiday for two weeks so unlikely to be able to comment further
> on it)
>
>
> Index: src/port/Makefile
> ===================================================================
> RCS file: /projects/cvsroot/pgsql-server/src/port/Makefile,v
> retrieving revision 1.5
> diff -u -r1.5 Makefile
> --- src/port/Makefile   8 Aug 2003 02:55:08 -0000       1.5
> +++ src/port/Makefile   9 Aug 2003 19:42:53 -0000
> @@ -23,7 +23,7 @@
>         $(AR) crs $@ $^
>
>  thread.o: thread.c
> -       $(CC) $(CFLAGS) $(CPPFLAGS) $(THREAD_CFLAGS) -c thread.c
> +       $(CC) $(CFLAGS) $(CPPFLAGS) $(THREAD_CFLAGS) -c $<
>
>  clean distclean maintainer-clean:
>         rm -f libpgport.a $(LIBOBJS)
>
> --
> John Gray <jgray@azuli.co.uk>
> Azuli IT
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073