Обсуждение: Antw: Re: Patch for NetWare support

Поиск
Список
Период
Сортировка

Antw: Re: Patch for NetWare support

От
"Ulrich Neumann"
Дата:
Hi Bruce,

at the moment NetWare doesn't have symbolic links so it's the only
chance for me to decide between postmaster, bootstrap or normal
interactive backend.

Sorry for that. Novell will add symbolic and hard links to the file
system
but they don't have it yet. As soon as they have links we can remove
the
code.

Ulrich

>>> Bruce Momjian <pgman@candle.pha.pa.us> 09.08.2002 00:47:21 >>>

I wish we didn't have to add this part of the patch to main.c:

+       /*
+        * If the first argument is "-post", then invoke postmaster
mode. Note
+        * we remove "-post" from the arguments passed on to
BootstrapMain.
+     * This is added for one reasons: NetWare doesn't have symbolic
links
+     * right. ((
+        */
+       if (argc > 1 && strcmp(new_argv[1], "-post") == 0)
+               exit(PostmasterMain(argc - 1, new_argv + 1));

Do we have to document this, but only for Netware?  Yuck.

---------------------------------------------------------------------------

Ulrich Neumann wrote:
> Hello,
>
> attached is a patch for main.c.
>
> The files netware.h and netware.c are for src/backend/port/dynloader
>
> Can anybody create the directory netware at src/backend/port?
>
>
> The changes in main.c are very small and i've documented them in the
> sourcecode.
>
>
> Thank you.
>
> Ulrich
>
> ----------------------------------
>   This e-mail is virus scanned
>   Diese e-mail ist virusgeprueft

[ Attachment, skipping... ]

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of
broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to
majordomo@postgresql.org

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania
19026

---------------------------(end of
broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to
majordomo@postgresql.org
----------------------------------
  This e-mail is virus scanned
  Diese e-mail ist virusgeprueft


Re: Antw: Re: Patch for NetWare support

От
Peter Eisentraut
Дата:
Ulrich Neumann writes:

> at the moment NetWare doesn't have symbolic links so it's the only
> chance for me to decide between postmaster, bootstrap or normal
> interactive backend.

Does it have hard links?  Does it have 'ln' at all?  Otherwise we should
define $(LN_S) to 'cp' and just make a copy.  That way we avoid patching
up the code.

--
Peter Eisentraut   peter_e@gmx.net


Re: Antw: Re: Patch for NetWare support

От
Alvaro Herrera
Дата:
Peter Eisentraut dijo:

> Ulrich Neumann writes:
>
> > at the moment NetWare doesn't have symbolic links so it's the only
> > chance for me to decide between postmaster, bootstrap or normal
> > interactive backend.
>
> Does it have hard links?  Does it have 'ln' at all?  Otherwise we should
> define $(LN_S) to 'cp' and just make a copy.  That way we avoid patching
> up the code.

Doesn't the cp trick invalidate the fork-no-exec performance
optimization?

--
Alvaro Herrera (<alvherre[a]atentus.com>)
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)


Re: Antw: Re: Patch for NetWare support

От
Tom Lane
Дата:
Alvaro Herrera <alvherre@atentus.com> writes:
> Peter Eisentraut dijo:
>> Does it have hard links?  Does it have 'ln' at all?  Otherwise we should
>> define $(LN_S) to 'cp' and just make a copy.  That way we avoid patching
>> up the code.

> Doesn't the cp trick invalidate the fork-no-exec performance
> optimization?

No.

            regards, tom lane