Обсуждение: src/backend/commands/sequence.c

Small patch to correct a change in type.  On BeOS bool <> char!

Also, shouldn't int32 be %ld not %d?

Index: src/backend/commands/sequence.c
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/src/backend/commands/
sequence.c,v
retrieving revision 1.39
diff -u -u -r1.39 sequence.c
--- src/backend/commands/sequence.c     2000/10/11 15:31:34     1.39
+++ src/backend/commands/sequence.c     2000/10/14 16:42:21
@@ -61,7 +61,7 @@
 static Form_pg_sequence read_info(char *caller, SeqTable elm, Buffer *
buf);
 static void init_params(CreateSeqStmt *seq, Form_pg_sequence new);
 static int     get_param(DefElem *def);
-static void do_setval(char *seqname, int32 next, char iscalled);
+static void do_setval(char *seqname, int32 next, bool iscalled);

 /*
  * DefineSequence

"David Reid" <dreid@jetnet.co.uk> writes:
> Small patch to correct a change in type.  On BeOS bool <> char!

Good catch (looks like Philip was a tad sloppy).

> Also, shouldn't int32 be %ld not %d?

No.  At least not on machines where long is 64 bits.  We don't support
machines where int is 16 bits, anyway.

            regards, tom lane

At 12:50 14/10/00 -0400, Tom Lane wrote:
>"David Reid" <dreid@jetnet.co.uk> writes:
>> Small patch to correct a change in type.  On BeOS bool <> char!
>
>Good catch (looks like Philip was a tad sloppy).
>

Quite right - a last minute to change to what was being passed, and I
missed the declaration.


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                 |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/

At 17:37 14/10/00 GMT, David Reid wrote:
>Small patch to correct a change in type.  On BeOS bool <> char!

Done. Thanks.


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.B.N. 75 008 659 498)          |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|
                                 |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/