Обсуждение: Help reviewing PR's

Поиск
Список
Период
Сортировка

Help reviewing PR's

От
Dave Cramer
Дата:
Currently there are a number of PR's on github that need reviewing.

I am wondering if someone can have a look at these other than the author.


Dave Cramer

Re: Help reviewing PR's

От
Steven Schlansker
Дата:
On Jun 17, 2015, at 9:10 AM, Dave Cramer <davecramer@gmail.com> wrote:

> Currently there are a number of PR's on github that need reviewing.
>
> I am wondering if someone can have a look at these other than the author.

I’ve given most of the PRs that did not already have a NAK from a committer a once over.  I can’t promise to have done
anexhaustive job but I tried to leave some constructive comments.

Re: Help reviewing PR's

От
Dave Cramer
Дата:
Steven,

Thanks!

Dave Cramer

On 21 June 2015 at 21:27, Steven Schlansker <stevenschlansker@gmail.com> wrote:
On Jun 17, 2015, at 9:10 AM, Dave Cramer <davecramer@gmail.com> wrote:

> Currently there are a number of PR's on github that need reviewing.
>
> I am wondering if someone can have a look at these other than the author.

I’ve given most of the PRs that did not already have a NAK from a committer a once over.  I can’t promise to have done an exhaustive job but I tried to leave some constructive comments.