Обсуждение: Why does BaseDataSource.setUrl() throw SQLException?

Hi,

BaseDataSource.setUrl()'s signature claims it throws SQLException but
looking at the code, it never does. Similarly, the documentation claims it
throws this exception yet fails to explain under what circumstances.

Can you please review whether this exception can be removed?

Thank you,
Gili



--
View this message in context:
http://postgresql.1045698.n5.nabble.com/Why-does-BaseDataSource-setUrl-throw-SQLException-tp5819281.html
Sent from the PostgreSQL - jdbc mailing list archive at Nabble.com.

Seems to be removable. No other interface declares it this way

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 17 September 2014 00:08, cowwoc <cowwoc@bbs.darktech.org> wrote:

Hi,

BaseDataSource.setUrl()'s signature claims it throws SQLException but
looking at the code, it never does. Similarly, the documentation claims it
throws this exception yet fails to explain under what circumstances.

Can you please review whether this exception can be removed?

Thank you,
Gili



--
View this message in context: http://postgresql.1045698.n5.nabble.com/Why-does-BaseDataSource-setUrl-throw-SQLException-tp5819281.html
Sent from the PostgreSQL - jdbc mailing list archive at Nabble.com.


--
Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-jdbc

post a bug on github, or better yet post a pull request on github

Dave

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 17 September 2014 09:18, cowwoc <cowwoc@bbs.darktech.org> wrote:

Okay good.

Is there a bug tracker for this project or do you normally handle things from this point?

Thanks,
Gili

On 17/09/2014 5:41 AM, Dave Cramer wrote:

Seems to be removable. No other interface declares it this way

Dave Cramer

dave.cramer(at)credativ(dot)ca
http://www.credativ.ca

On 17 September 2014 00:08, cowwoc <cowwoc@bbs.darktech.org> wrote:

Hi,

BaseDataSource.setUrl()'s signature claims it throws SQLException but
looking at the code, it never does. Similarly, the documentation claims it
throws this exception yet fails to explain under what circumstances.

Can you please review whether this exception can be removed?

Thank you,
Gili



--
View this message in context: http://postgresql.1045698.n5.nabble.com/Why-does-BaseDataSource-setUrl-throw-SQLException-tp5819281.html
Sent from the PostgreSQL - jdbc mailing list archive at Nabble.com.


--
Sent via pgsql-jdbc mailing list (pgsql-jdbc@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-jdbc

On Wed, Sep 17, 2014 at 7:38 AM, cowwoc <cowwoc@bbs.darktech.org> wrote:
> Done: https://github.com/pgjdbc/pgjdbc/pull/186
Note that Travis is complaining about this patch at its current state.
--
Michael

On 17/09/2014 12:35 PM, Michael Paquier wrote:
> On Wed, Sep 17, 2014 at 7:38 AM, cowwoc <cowwoc@bbs.darktech.org> wrote:
>> Done: https://github.com/pgjdbc/pgjdbc/pull/186
> Note that Travis is complaining about this patch at its current state.

Looks like a build problem (nothing to do with my patch). See
https://travis-ci.org/pgjdbc/pgjdbc/jobs/35541539

Gili