Обсуждение: Submission of new DefaultProperties class
(This is a resend, since I think the first one got lost in the mailer) Folks- I'm not sure that the mailing list is working, but I wanted to send this to the group. I've got two files that help with default configuration. The first is the DefaultProperties.java file, which belongs in the org/postgresql/util directory. This file contains methods to get, well, default properties. The default properties can either the system defaults in the org/postgresl/psqlProps.properties file (which I included as well)or the user defined psqlProps.properties. Both files should be included in the jars that are built, and are not java version specific. They use standard property classes, and are minimal in size. A singleton reference to the class is there as well, so different components can share it. Properties can be reloaded. Finally, note that the user defaults override the system defaults, but the user psqlProps.properties doesn't need to contain all the system ones. Just the ones they want changed. I've included the two files here, and copies are at my website (http://members.home.net/wolpert5/code/) Let me know of any problems or suggestions. I'm going to use this for the pooling code I'm going to contribute. Thanks ===== Virtually, | "Must you shout too?" Ned Wolpert | -Dante wolpert@yahoo.com | _________________/ "Who watches the watchmen?" 4e75 -Juvenal, 120 AD -- Place your commercial here -- fnord __________________________________________________ Do You Yahoo!? Find a job, post your resume. http://careers.yahoo.com
Вложения
Ned Wolpert writes: > I'm not sure that the mailing list is working, but I wanted to send > this to the group. I've got two files that help with default > configuration. The first is the DefaultProperties.java file, which > belongs in the org/postgresql/util directory. This file contains > methods to get, well, default properties. The default properties can > either the system defaults in the org/postgresl/psqlProps.properties > file (which I included as well)or the user defined psqlProps.properties. Just a nit: You should probably avoid naming stuff "psql" unless it's got to do with "psql". "PGstuff" is an acceptable naming convention. -- Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter
Ok, howabout naming the file pg.properties instead of psqlProps.properties? Other choices are pgDriver.properties? --- Peter Eisentraut <peter_e@gmx.net> wrote: > Ned Wolpert writes: > > > I'm not sure that the mailing list is working, but I wanted to send > > this to the group. I've got two files that help with default > > configuration. The first is the DefaultProperties.java file, which > > belongs in the org/postgresql/util directory. This file contains > > methods to get, well, default properties. The default properties can > > either the system defaults in the org/postgresl/psqlProps.properties > > file (which I included as well)or the user defined > psqlProps.properties. > > Just a nit: You should probably avoid naming stuff "psql" unless it's > got > to do with "psql". "PGstuff" is an acceptable naming convention. > > -- > Peter Eisentraut peter_e@gmx.net http://funkturm.homeip.net/~peter > ===== Virtually, | "Must you shout too?" Ned Wolpert | -Dante wolpert@yahoo.com | _________________/ "Who watches the watchmen?" 4e75 -Juvenal, 120 AD -- Place your commercial here -- fnord __________________________________________________ Do You Yahoo!? Find a job, post your resume. http://careers.yahoo.com
Your patch has been added to the PostgreSQL unapplied patches list at:
http://candle.pha.pa.us/cgi-bin/pgpatches
I will try to apply it within the next 48 hours. JDBC maintainers will
review.
---------------------------------------------------------------------------
Ned Wolpert wrote:
> (This is a resend, since I think the first one got lost in the mailer)
>
> Folks-
> I'm not sure that the mailing list is working, but I wanted to send
> this to the group. I've got two files that help with default
> configuration. The first is the DefaultProperties.java file, which
> belongs in the org/postgresql/util directory. This file contains
> methods to get, well, default properties. The default properties can
> either the system defaults in the org/postgresl/psqlProps.properties
> file (which I included as well)or the user defined psqlProps.properties.
>
> Both files should be included in the jars that are built, and are not
> java version specific. They use standard property classes, and are
> minimal in size. A singleton reference to the class is there as well,
> so different components can share it. Properties can be reloaded.
>
> Finally, note that the user defaults override the system defaults, but
> the user psqlProps.properties doesn't need to contain all the system
> ones. Just the ones they want changed.
>
> I've included the two files here, and copies are at my website
> (http://members.home.net/wolpert5/code/) Let me know of any problems or
> suggestions. I'm going to use this for the pooling code I'm going to
> contribute.
>
> Thanks
>
>
>
>
>
> =====
> Virtually, | "Must you shout too?"
> Ned Wolpert | -Dante
> wolpert@yahoo.com |
> _________________/ "Who watches the watchmen?"
> 4e75 -Juvenal, 120 AD
>
> -- Place your commercial here -- fnord
>
> __________________________________________________
> Do You Yahoo!?
> Find a job, post your resume.
> http://careers.yahoo.com
Content-Description: DefaultProperties.java
[ Attachment, skipping... ]
Content-Description: psqlProps.properties
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 5: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/users-lounge/docs/faq.html
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026