Обсуждение: Small patch: fix double variable initializations in policy.c

Hello

I discovered a pretty weird code.

policy.c:1083

```
char       *qual_value;
ParseState *qual_pstate = make_parsestate(NULL);

/* parsestate is built just to build the range table */
qual_pstate = make_parsestate(NULL);
```

policy.c:1125

```
char       *with_check_value;
ParseState *with_check_pstate = make_parsestate(NULL);

/* parsestate is built just to build the range table */
with_check_pstate = make_parsestate(NULL);
```

I'm quite sure that there is no need to initialize these variables
twice. First patch fixes this. Also I discovered that policy.c is not
properly pgindent'ed. Second patch fixes this too.

Naturally I checked that after applying these patches PostgreSQL still
compiles and pass all regression tests.

--
Best regards,
Aleksander Alekseev
http://eax.me/

Aleksander Alekseev <a.alekseev@postgrespro.ru> writes:
> I'm quite sure that there is no need to initialize these variables
> twice. First patch fixes this. Also I discovered that policy.c is not
> properly pgindent'ed. Second patch fixes this too.

Applied the first patch --- though I chose to do it the other way
(keep the declaration and assignment separate) because as you had it,
pgindent would've inserted an ugly/confusing blank line within the
declarations stanza of the block.

With the end of the devel cycle fast approaching, we might as well leave
it to the regular pgindent run to clean up the other issues.  People tend
to complain if you invalidate pending patches at this time of year ;-)

Thanks for catching this!
        regards, tom lane