Обсуждение: Commit fest status for 2015-11

Hi all,

As of today, at the moment I am writing this message, here is the
commit fest app status:
Needs review: 20.
Waiting on Author: 24.
Ready for Committer: 4.
Committed: 29.
Moved to next CF: 11.
Rejected: 8.
Returned with Feedback: 7.
Total: 103.

This means in short that 48 out of 103 patches still need to be
treated by the end of this commit fest, which was actually 3 weeks
ago. As the so-said CFM, perhaps I slacked a bit too much here, but to
be honest at this rhythm we are not going to make it by the end of the
month, so I am going to look at the 48 remaining patches and see if
each one can be moved to the next commit fest or returned with
feedback. I would suspect as well that the status of some of those
patches has not been updated for a while.

It would be cool to get a largely cleaned up CF app by Christmas, or
err... 3 days. This is going to be a vacation period and a lot of
people are not going to be here.

To patch authors: please be careful that the status of your patch is
correctly updated. And feel free to scream injustice regarding your
patch if you think the CFM was unfair. I'll update the related threads
regarding the status of the patch, so feel free to complain if needed
on the related thread.
To reviewers: thanks for the reviews done!
To committers: there are 4 patches waiting for input.

Regards,
-- 
Michael

Michael Paquier <michael.paquier@gmail.com> writes:
> To committers: there are 4 patches waiting for input.

Those are:

: SQL function to report log message

AFAICT, there is no committer who likes this idea enough to commit it.
It's questionable whether we need such a feature at all, and it's even
more questionable whether this particular instantiation of the feature
is well-designed.  I'm not going to opine as to whether it should get
marked "returned with feedback" or "rejected", but I doubt it's going
to get committed as-is.

: Reusing abbreviated keys during second pass of ordered [set] aggregates

Robert has been committer for all the predecessor patches, so I assume
this one will be his.

: Speedup timestamp/time/date output functions

I'd look into this if Andres hadn't already claimed it ...

: Improving replay of XLOG_BTREE_VACUUM records

Heikki and Andres have already reviewed this, so I assume one or the
other of them will be committer.
        regards, tom lane

On Tue, Dec 22, 2015 at 3:35 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> To committers: there are 4 patches waiting for input.
>
> Those are:
>
> : SQL function to report log message
>
> AFAICT, there is no committer who likes this idea enough to commit it.
> It's questionable whether we need such a feature at all, and it's even
> more questionable whether this particular instantiation of the feature
> is well-designed.  I'm not going to opine as to whether it should get
> marked "returned with feedback" or "rejected", but I doubt it's going
> to get committed as-is.

Thanks, that's hard to follow all those threads. Let's cut the apple
in half and mark it as returned with feedback then.

> : Reusing abbreviated keys during second pass of ordered [set] aggregates
>
> Robert has been committer for all the predecessor patches, so I assume
> this one will be his.
>
> : Speedup timestamp/time/date output functions
>
> I'd look into this if Andres hadn't already claimed it ...
>
> : Improving replay of XLOG_BTREE_VACUUM records
>
> Heikki and Andres have already reviewed this, so I assume one or the
> other of them will be committer.

OK, if those don't get addressed soon, they will be moved to the next
CF with the same status.
-- 
Michael

On Tue, Dec 22, 2015 at 4:04 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> OK, if those don't get addressed soon, they will be moved to the next
> CF with the same status.

After a first pass, Numbers are getting down,  I am just too tired to continue:
Needs review: 13.
Waiting on Author: 15.
Ready for Committer: 5

Two additional patches have been marked as ready for committer:
1) Bug fix for pg_dump --jobs when password is passed a a parameter in
a connection string:
https://commitfest.postgresql.org/7/405/
2) Default roles, in Stephen's plate:
https://commitfest.postgresql.org/7/49/
Regards,
-- 
Michael

On Tue, Dec 22, 2015 at 10:45 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Dec 22, 2015 at 4:04 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> OK, if those don't get addressed soon, they will be moved to the next
>> CF with the same status.
>
> After a first pass, Numbers are getting down,  I am just too tired to continue:
> Needs review: 13.
> Waiting on Author: 15.
> Ready for Committer: 5
>
> Two additional patches have been marked as ready for committer:
> 1) Bug fix for pg_dump --jobs when password is passed a a parameter in
> a connection string:
> https://commitfest.postgresql.org/7/405/
> 2) Default roles, in Stephen's plate:
> https://commitfest.postgresql.org/7/49/

I had a look at all the remaining entries and treated each one of
them, patches marked as ready for committer have been moved to next CF
with the same status. There are currently 3 remaining entries in the
CF app where it would be cool authors and/or reviewers give a status
of the situation. Once this is addressed the CF of 2015-11 will be
closed.

Note particularly to authors: if your patch has been returned with
feedback, but you are still working on it, please make sure that it is
moved to next CF soon. Or, if your patch has been moved to next CF,
*but* you are not working on it, it would be nice to mark it as
returned with feedback in 2016-01.
Thanks.
-- 
Michael

On Thu, Dec 24, 2015 at 12:09 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Tue, Dec 22, 2015 at 10:45 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>> On Tue, Dec 22, 2015 at 4:04 PM, Michael Paquier
>> <michael.paquier@gmail.com> wrote:
>>> OK, if those don't get addressed soon, they will be moved to the next
>>> CF with the same status.
>>
>> After a first pass, Numbers are getting down,  I am just too tired to continue:
>> Needs review: 13.
>> Waiting on Author: 15.
>> Ready for Committer: 5
>>
>> Two additional patches have been marked as ready for committer:
>> 1) Bug fix for pg_dump --jobs when password is passed a a parameter in
>> a connection string:
>> https://commitfest.postgresql.org/7/405/
>> 2) Default roles, in Stephen's plate:
>> https://commitfest.postgresql.org/7/49/
>
> I had a look at all the remaining entries and treated each one of
> them, patches marked as ready for committer have been moved to next CF
> with the same status. There are currently 3 remaining entries in the
> CF app where it would be cool authors and/or reviewers give a status
> of the situation. Once this is addressed the CF of 2015-11 will be
> closed.
>
> Note particularly to authors: if your patch has been returned with
> feedback, but you are still working on it, please make sure that it is
> moved to next CF soon. Or, if your patch has been moved to next CF,
> *but* you are not working on it, it would be nice to mark it as
> returned with feedback in 2016-01.

And the CF is no closed. Here is the final score:
Committed: 30.
Moved to next CF: 42.
Rejected: 9.
Returned with Feedback: 22.
Total: 103.
Regards,
-- 
Michael

Michael Paquier <michael.paquier@gmail.com> writes:
> And the CF is no closed. Here is the final score:
> Committed: 30.
> Moved to next CF: 42.
> Rejected: 9.
> Returned with Feedback: 22.
> Total: 103.

Many thanks to Michael for doing the CF management work this time!
        regards, tom lane

On 12/24/2015 04:18 PM, Tom Lane wrote:
> Michael Paquier <michael.paquier@gmail.com> writes:
>> And the CF is no closed. Here is the final score:
>> Committed: 30.
>> Moved to next CF: 42.
>> Rejected: 9.
>> Returned with Feedback: 22.
>> Total: 103.
>
> Many thanks to Michael for doing the CF management work this time!

+1

--
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On 25/12/15 01:45, Michael Paquier wrote:
[...]
> And the CF is no closed. Here is the final score:
> Committed: 30.
> Moved to next CF: 42.
> Rejected: 9.
> Returned with Feedback: 22.
> Total: 103.
> Regards,

You didn't say how may regards...


[More seriously]
Many thanks to you, and the other Postgres developers, for all your hard 
work & dedication, much appreciated!



Cheers,
Gavin

On Fri, Dec 25, 2015 at 5:20 AM, Gavin Flower
<GavinFlower@archidevsys.co.nz> wrote:
> On 25/12/15 01:45, Michael Paquier wrote:
> [...]
>>
>> And the CF is no closed. Here is the final score:
>> Committed: 30.
>> Moved to next CF: 42.
>> Rejected: 9.
>> Returned with Feedback: 22.
>> Total: 103.
>> Regards,
>
>
> You didn't say how may regards...

One.

> [More seriously]
> Many thanks to you, and the other Postgres developers, for all your hard
> work & dedication, much appreciated!

Thanks. I am moving back to more normal hacking activity, and there is
much to be done. Being a CFM is highly energy-draining activity.
-- 
Michael

On Thu, Dec 24, 2015 at 09:45:40PM +0900, Michael Paquier wrote:
> On Thu, Dec 24, 2015 at 12:09 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
> > On Tue, Dec 22, 2015 at 10:45 PM, Michael Paquier
> > <michael.paquier@gmail.com> wrote:
> >> On Tue, Dec 22, 2015 at 4:04 PM, Michael Paquier
> >> <michael.paquier@gmail.com> wrote:
> >>> OK, if those don't get addressed soon, they will be moved to the next
> >>> CF with the same status.
> >>
> >> After a first pass, Numbers are getting down,  I am just too tired to continue:
> >> Needs review: 13.
> >> Waiting on Author: 15.
> >> Ready for Committer: 5
> >>
> >> Two additional patches have been marked as ready for committer:
> >> 1) Bug fix for pg_dump --jobs when password is passed a a parameter in
> >> a connection string:
> >> https://commitfest.postgresql.org/7/405/
> >> 2) Default roles, in Stephen's plate:
> >> https://commitfest.postgresql.org/7/49/
> >
> > I had a look at all the remaining entries and treated each one of
> > them, patches marked as ready for committer have been moved to next CF
> > with the same status. There are currently 3 remaining entries in the
> > CF app where it would be cool authors and/or reviewers give a status
> > of the situation. Once this is addressed the CF of 2015-11 will be
> > closed.
> >
> > Note particularly to authors: if your patch has been returned with
> > feedback, but you are still working on it, please make sure that it is
> > moved to next CF soon. Or, if your patch has been moved to next CF,
> > *but* you are not working on it, it would be nice to mark it as
> > returned with feedback in 2016-01.
> 
> And the CF is no closed. Here is the final score:
> Committed: 30.
> Moved to next CF: 42.
> Rejected: 9.
> Returned with Feedback: 22.
> Total: 103.
> Regards,

Thanks very much for doing the thankless!

Cheers,
David.
-- 
David Fetter <david@fetter.org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david.fetter@gmail.com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate