Обсуждение: Supporting src/test/modules in MSVC builds
Hi all, As mentioned previously (CAB7nPqSCphafxS2RzeB-FBccjqiKnQXJhLoZtkggiM1MF5Xv4A@mail.gmail.com), attached are patches to add support for src/test/modules in MSVC builds, modules whose tests are not supported since they have been moved from contrib/: - 0001 adds support for the build portion. - 0002 adds support for the installation. I arrived at the conclusion that those modules should be installed by default, because contribcheck relies on the fact that tests should be run on a server already running, and modulescheck should do the same IMO. - 0003 adds a new target modulescheck in vcregress. Patches 0001 and 0003 are based on some previous work from Alvaro, that I modified slightly after testing them. Note that this split is done to test each step on the build farm for safety. Regards, -- Michael
Вложения
On 04/16/2015 02:46 AM, Michael Paquier wrote: > Hi all, > > As mentioned previously > (CAB7nPqSCphafxS2RzeB-FBccjqiKnQXJhLoZtkggiM1MF5Xv4A@mail.gmail.com), > attached are patches to add support for src/test/modules in MSVC > builds, modules whose tests are not supported since they have been > moved from contrib/: > - 0001 adds support for the build portion. > - 0002 adds support for the installation. I arrived at the conclusion > that those modules should be installed by default, because > contribcheck relies on the fact that tests should be run on a server > already running, and modulescheck should do the same IMO. > - 0003 adds a new target modulescheck in vcregress. > > Patches 0001 and 0003 are based on some previous work from Alvaro, > that I modified slightly after testing them. Note that this split is > done to test each step on the build farm for safety. > Regards, > Thanks for doing this. It looks good, and if you've tested it I'm satisfied. I suggest that we apply patches 1 and 2 immediately. AUIU they don't require any changes to the buildfarm, as the MSVC build process will automatically build and install it with these changes. Then if all goes well we can apply the third patch and I'll fix the buildfarm client for the forthcoming release to run the tests on MSVC builds. Nothing will break in the meantime - the tests just won't get run until the new client version is deployed. cheers andrew
Andrew Dunstan wrote: > Thanks for doing this. Yes, much appreciated. > It looks good, and if you've tested it I'm satisfied. I suggest that > we apply patches 1 and 2 immediately. AUIU they don't require any > changes to the buildfarm, as the MSVC build process will automatically > build and install it with these changes. Okay, I just pushed patches 1 and 2. > Then if all goes well we can apply the third patch and I'll fix the > buildfarm client for the forthcoming release to run the tests on MSVC > builds. Nothing will break in the meantime - the tests just won't get > run until the new client version is deployed. Will wait for a day or so to see what the Win buildfarm members say. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Fri, Apr 17, 2015 at 4:47 AM, Alvaro Herrera wrote: > Andrew Dunstan wrote: >> It looks good, and if you've tested it I'm satisfied. I suggest that >> we apply patches 1 and 2 immediately. AUIU they don't require any >> changes to the buildfarm, as the MSVC build process will automatically >> build and install it with these changes. > > Okay, I just pushed patches 1 and 2. Cool, thanks. >> Then if all goes well we can apply the third patch and I'll fix the >> buildfarm client for the forthcoming release to run the tests on MSVC >> builds. Nothing will break in the meantime - the tests just won't get >> run until the new client version is deployed. > > Will wait for a day or so to see what the Win buildfarm members say. currawong and mastodon seem satisfied. -- Michael
On 04/16/2015 07:42 PM, Michael Paquier wrote: > >>> Then if all goes well we can apply the third patch and I'll fix the >>> buildfarm client for the forthcoming release to run the tests on MSVC >>> builds. Nothing will break in the meantime - the tests just won't get >>> run until the new client version is deployed. >> Will wait for a day or so to see what the Win buildfarm members say. > currawong and mastodon seem satisfied. Yeah. I think we can push the third one - I am just about ready to release the new buildfarm client.
Andrew Dunstan wrote: > > On 04/16/2015 07:42 PM, Michael Paquier wrote: > > > >>>Then if all goes well we can apply the third patch and I'll fix the > >>>buildfarm client for the forthcoming release to run the tests on MSVC > >>>builds. Nothing will break in the meantime - the tests just won't get > >>>run until the new client version is deployed. > >>Will wait for a day or so to see what the Win buildfarm members say. > >currawong and mastodon seem satisfied. > > Yeah. I think we can push the third one - I am just about ready to release > the new buildfarm client. Pushed. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Fri, Apr 17, 2015 at 11:41 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > Andrew Dunstan wrote: >> >> On 04/16/2015 07:42 PM, Michael Paquier wrote: >> > >> >>>Then if all goes well we can apply the third patch and I'll fix the >> >>>buildfarm client for the forthcoming release to run the tests on MSVC >> >>>builds. Nothing will break in the meantime - the tests just won't get >> >>>run until the new client version is deployed. >> >>Will wait for a day or so to see what the Win buildfarm members say. >> >currawong and mastodon seem satisfied. >> >> Yeah. I think we can push the third one - I am just about ready to release >> the new buildfarm client. > > Pushed. And currawong is satisfied with this patch and the new buildfarm code, test modules being run as testmodules-install-check-C: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-18%2014%3A51%3A14 So this closes the loop for this thread. -- Michael
Michael Paquier wrote: > And currawong is satisfied with this patch and the new buildfarm code, > test modules being run as testmodules-install-check-C: > http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=currawong&dt=2015-04-18%2014%3A51%3A14 > So this closes the loop for this thread. Yay! Thanks, Michael and Andrew. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services