Обсуждение: Typo fixes for pg_recvlogical documentation

On Thu, Oct 23, 2014 at 10:00 AM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> pg_recvlogical is missing some "=" signs for a couple of option names where
> double-dash is used, like this one:
> --username user
> should be that:
> --username=user
>
> Attached is a patch correcting that.

For reasons that are not clear to me, I cannot apply this patch.

[rhaas pgsql]$ patch -p1 < ~/Downloads/20141023_pg_recvlogical_fixes.patch
patching file doc/src/sgml/ref/pg_recvlogical.sgml
Hunk #1 succeeded at 270 with fuzz 1 (offset 165 lines).
Hunk #2 FAILED at 282.
Hunk #3 FAILED at 295.
Hunk #4 FAILED at 308.
3 out of 4 hunks FAILED -- saving rejects to file
doc/src/sgml/ref/pg_recvlogical.sgml.rej

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Fri, Oct 24, 2014 at 7:42 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> [rhaas pgsql]$ patch -p1 < ~/Downloads/20141023_pg_recvlogical_fixes.patch
> patching file doc/src/sgml/ref/pg_recvlogical.sgml
> Hunk #1 succeeded at 270 with fuzz 1 (offset 165 lines).
> Hunk #2 FAILED at 282.
> Hunk #3 FAILED at 295.
> Hunk #4 FAILED at 308.
> 3 out of 4 hunks FAILED -- saving rejects to file
> doc/src/sgml/ref/pg_recvlogical.sgml.rej
Sorry, I did not rebase much these days, there were conflicts with 52c1ae2...
--
Michael

On Fri, Oct 24, 2014 at 5:14 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Fri, Oct 24, 2014 at 7:42 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> [rhaas pgsql]$ patch -p1 < ~/Downloads/20141023_pg_recvlogical_fixes.patch
>> patching file doc/src/sgml/ref/pg_recvlogical.sgml
>> Hunk #1 succeeded at 270 with fuzz 1 (offset 165 lines).
>> Hunk #2 FAILED at 282.
>> Hunk #3 FAILED at 295.
>> Hunk #4 FAILED at 308.
>> 3 out of 4 hunks FAILED -- saving rejects to file
>> doc/src/sgml/ref/pg_recvlogical.sgml.rej
> Sorry, I did not rebase much these days, there were conflicts with 52c1ae2...

Committed and back-patched to 9.4.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Oct 28, 2014 at 12:12 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> Committed and back-patched to 9.4.
Thanks.
-- 
Michael