Обсуждение: Fwd: Typo fixes in Solution.pm, part of MSVC scripts

Поиск
Список
Период
Сортировка

Fwd: Typo fixes in Solution.pm, part of MSVC scripts

От
Michael Paquier
Дата:
Hi all,

I noticed a couple of typos in Solution.pm, fixed by the patch
attached. Those things have been introduced by commits cec8394 (visual
2013 support) and 0a78320 (latest pgident run, not actually a problem
of pgident, because of a misuse of commas).
The tab problems should not be backpatched to 9.3, but the use of
commas instead of semicolons should be.

Regards,
--
Michael

Вложения

Re: Fwd: Typo fixes in Solution.pm, part of MSVC scripts

От
Robert Haas
Дата:
On Sun, May 25, 2014 at 11:34 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> I noticed a couple of typos in Solution.pm, fixed by the patch
> attached. Those things have been introduced by commits cec8394 (visual
> 2013 support) and 0a78320 (latest pgident run, not actually a problem
> of pgident, because of a misuse of commas).
> The tab problems should not be backpatched to 9.3, but the use of
> commas instead of semicolons should be.

I suspect it would be good, then, to separate this into two patches,
one for back-patch and one not.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Re: Fwd: Typo fixes in Solution.pm, part of MSVC scripts

От
Michael Paquier
Дата:
On Fri, May 30, 2014 at 4:31 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> I suspect it would be good, then, to separate this into two patches,
> one for back-patch and one not.
Attached are patches for master and 9.3. 9.2 and older versions are
not impacted.
Regards,
--
Michael

Вложения

Re: Fwd: Typo fixes in Solution.pm, part of MSVC scripts

От
Heikki Linnakangas
Дата:
On 05/30/2014 10:25 AM, Michael Paquier wrote:
> On Fri, May 30, 2014 at 4:31 AM, Robert Haas <robertmhaas@gmail.com> wrote:
>> I suspect it would be good, then, to separate this into two patches,
>> one for back-patch and one not.
> Attached are patches for master and 9.3. 9.2 and older versions are
> not impacted.

Thanks, applied.

- Heikki