Обсуждение: Header comments in the recently added files
I found trivial mistakes in the recently added files. Will they fixed by some automated batches, or by manual? - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group" in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h,pg_backup_directory.c and auth_delay.c. - "IDENTIFICATION $PostgreSQL$" in pg_collation.h, syncrep.h, and syncrep.c Other files has their actual paths in the sameplace. -- Itagaki Takahiro
On Wed, Mar 9, 2011 at 8:33 PM, Itagaki Takahiro <itagaki.takahiro@gmail.com> wrote: > I found trivial mistakes in the recently added files. > Will they fixed by some automated batches, or by manual? > > - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group" > in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h, > pg_backup_directory.c and auth_delay.c. > - "IDENTIFICATION $PostgreSQL$" in pg_collation.h, syncrep.h, and syncrep.c > Other files has their actual paths in the same place. I think these should be fixed manually. The first might eventually get fixed automatically, but perhaps not until 2012, and I'm not sure the second would ever get fixed automatically. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Thu, Mar 10, 2011 at 12:55, Robert Haas <robertmhaas@gmail.com> wrote: > On Wed, Mar 9, 2011 at 8:33 PM, Itagaki Takahiro > <itagaki.takahiro@gmail.com> wrote: >> I found trivial mistakes in the recently added files. >> Will they fixed by some automated batches, or by manual? > I think these should be fixed manually. The first might eventually > get fixed automatically, but perhaps not until 2012, and I'm not sure > the second would ever get fixed automatically. OK, I'll do that. -- Itagaki Takahiro
Itagaki Takahiro <itagaki.takahiro@gmail.com> writes:
> I found trivial mistakes in the recently added files.
> Will they fixed by some automated batches, or by manual?
> - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group"
> in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h,
> pg_backup_directory.c and auth_delay.c.
> - "IDENTIFICATION $PostgreSQL$" in pg_collation.h, syncrep.h, and syncrep.c
> Other files has their actual paths in the same place.
It might be worth Bruce making another run of his copyright-update
script to fix the former problems. As for the latter problems,
I have a to-do item to go around and standardize the format of the
header comments a bit better --- I'd like to have a uniform convention
that we put the full path name of each file at the top, and then get
rid of the vestigial "IDENTIFICATION" sections. Don't know quite when
I'll get to it though.
regards, tom lane
Tom Lane wrote: > Itagaki Takahiro <itagaki.takahiro@gmail.com> writes: > > I found trivial mistakes in the recently added files. > > Will they fixed by some automated batches, or by manual? > > > - "Copyright (c) xxx-*2010*, PostgreSQL Global Development Group" > > in pg_collation.h, pg_foreign_table.h, basebackup.h, syncrep.h, > > pg_backup_directory.c and auth_delay.c. > > - "IDENTIFICATION $PostgreSQL$" in pg_collation.h, syncrep.h, and syncrep.c > > Other files has their actual paths in the same place. > > It might be worth Bruce making another run of his copyright-update > script to fix the former problems. As for the latter problems, I ran it just now and nothing was changed, so we are OK now. -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + It's impossible for everything to be true. +