Обсуждение: CommitFest Status Summary - 2009-07-25
All, A few hours ago I assigned a reviewer to the last patch for this CommitFest which still lacked one, with the exception of Heikki's index-only quals patch, which I'm not sure can be reviewed at this point because it depends on the indexam API changes patch, which is still up in the air. One thing I have belatedly realized about this CommitFest is that we (or at least, I) did not think about asking the committers about their schedules, and it turns out that three of them - Heikki, Michael Meskes, Joe Conway - are away at the moment. About 25% of the remaining patches are waiting for one of those three people to take the next step (as either patch author, or reviewer, or committer). That's not exactly a catastrophe considering that we have informally decided that a CommitFest is about a month long, and we're only 10 days into it, but may mean that there's not much left for non-committers to do well before all of the patches are actually dealt with. I've attached below a summary of which patches are waiting on which people, to the best of my ability to determine such things. It's basically the same information that's on commitfest.postgresql.org, but broken up differently and annotated with notes here and there. There are a couple of patches that are ostensibly waiting on reviewer activity that may really be ready for committer; the others are reviews that aren't finished, and we may want to think about adding additional reviewers to help move things along. Also, there are a few patches that are waiting on author which are nearly done, and it may make sense for someone other than the patch author to pick them up and finish them so that we can move forward with them. Any thoughts/ideas/etc. welcome. ...Robert Specific Committers (13) - generic explain options v3 (needs further review by Tom Lane) - Indexam API changes (Heikki Linnakangas as patch author) - Index-only quals (Heikki Linnakangas as patch author) - Determine cient_encoding from client locale (Heikki Linnakangas as patch author) - plpythonu datatype conversion improvements (Peter Eisentraut as committer) - dependencies for generated header files (Peter Eisentraut as reviewer) - Fix memory leak in win32 security functions (Magnus Hagander as patch author and presumed committer) - ECPG dynamic cursor, SQLDA support (Michael Meskes as reviewer) - ECPG support for string pseudo-type v2 (Michael Meskes as reviewer) - async notifications for dblink (Joe Conway as reviewer) - query cancel issues in dblink (Joe Conway as reviewer) - has_sequence_privilege() function (Joe Conway as reviewer) - Polygons (Teodor Sigaev as committer) Unspecified Committer (4) - GRANT ON ALL IN schema - Provide support for multiplexing SIGUSR1 signal - Deferrable unique constraints - DefaultACLs Reviewer (10) - ALTER TABLE ... ALTER COLUMN ... SET DISTINCT - Revise parallel pg_restore's scheduling heuristic - Merge append - Support for EEEE in to_char() (may be ready for committer) - multi-threaded pgbench (may be ready for committer) - Improvements for dict_xsyn extended synonym dictionary - new bytea hex output format - return query and dropped columns (perhaps this should be marked ready for committer?) - Prefix support for synonym dictionary (just assigned) - Filtering dictionary support and unaccent dictionary (just assigned) Author (8) - Named and mixed notation for PL - \dL for languages - WIP: TODO Item 'Add prompt escape to display the client and server versions' - hstore enhancements - Lock wait statistics (Tom doesn't like it, may be doomed) - Parser's hook based on FuncCall (seems to need major expansion, may be too much for this CF) - autogenerating headers & bki stuff (Tom doesn't like it, may be doomed) - better support for win64 via intptr_t (seems to need major reworking, may be too much for this CF) Limbo (2) - machine-readable explain output v2 (can't update this patch until issues with generic explain options v3 are resolved) - report key values in duplicate-key errors (not really sure whose court the ball is in at this point)
Robert Haas <robertmhaas@gmail.com> writes:
> ... One thing I have belatedly realized about this
> CommitFest is that we (or at least, I) did not think about asking the
> committers about their schedules, and it turns out that three of them
> - Heikki, Michael Meskes, Joe Conway - are away at the moment. About
> 25% of the remaining patches are waiting for one of those three people
> to take the next step (as either patch author, or reviewer, or
> committer).
Well, any commitfest is going to have some issues of that sort,
especially one scheduled during the summer. If we get to the point
where those patches are the only ones left, and the relevant people
still aren't back, I think we can just push them all to the next fest.
But I doubt we are moving fast enough to make that happen.
> Specific Committers (13)
> - generic explain options v3 (needs further review by Tom Lane)
Actually I was waiting for the other EXPLAIN patch to come ready
before looking at this, because I thought they were intertwined.
Do you want this committed before that?
regards, tom lane
On Sun, Jul 26, 2009 at 12:07 PM, Tom Lane<tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> ... One thing I have belatedly realized about this >> CommitFest is that we (or at least, I) did not think about asking the >> committers about their schedules, and it turns out that three of them >> - Heikki, Michael Meskes, Joe Conway - are away at the moment. About >> 25% of the remaining patches are waiting for one of those three people >> to take the next step (as either patch author, or reviewer, or >> committer). > > Well, any commitfest is going to have some issues of that sort, > especially one scheduled during the summer. If we get to the point > where those patches are the only ones left, and the relevant people > still aren't back, I think we can just push them all to the next fest. > But I doubt we are moving fast enough to make that happen. I think Joe is back in the next week, but I'm not sure about Michael or Heikki. >> Specific Committers (13) >> - generic explain options v3 (needs further review by Tom Lane) > > Actually I was waiting for the other EXPLAIN patch to come ready > before looking at this, because I thought they were intertwined. > Do you want this committed before that? Well, if it's OK with you, yes. I have been maintaining these as a series of stacked patches, and the latest round of refactoring on the explain-options patch has broken the machine-readable explain output patch beyond all recognition. So it costs me nothing to have you whack it around some more before committing it at this point. I think it's an independent feature: it does a bunch of refactoring, adds new syntax, and adds an actual option which makes use of that syntax. Not the most interesting option, to be sure, but one that's been requested more than once. The other alternative is to merge the two patches together and then commit the whole thing in one go. I think I like this option a little less because it means that if there turn out to be additional issues with the machine-readable explain-patch, I might end up getting nothing that actually does anything committed this CommitFest, and it will also delay the process by several days while I rework and merge the patches. But I'm willing to do it if it's the only path to getting this done. What I'm LEAST enthusiastic about is fixing the machine-readable explain output patch, then have you make some more changes to explain-options patch, then having to fix machine-readable explain output again. ...Robert
Robert Haas wrote: > I think Joe is back in the next week, but I'm not sure about Michael or Heikki. I'll be back on Monday 3rd of August. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
--On Sonntag, Juli 26, 2009 15:43:28 -0400 Robert Haas
<robertmhaas@gmail.com> wrote:
> I think Joe is back in the next week, but I'm not sure about Michael or
> Heikki.
Michael is on vacation, he's back next week.
-- Thanks
Bernd
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Tom Lane wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> ... One thing I have belatedly realized about this >> CommitFest is that we (or at least, I) did not think about asking the >> committers about their schedules, and it turns out that three of them >> - Heikki, Michael Meskes, Joe Conway - are away at the moment. About >> 25% of the remaining patches are waiting for one of those three people >> to take the next step (as either patch author, or reviewer, or >> committer). > > Well, any commitfest is going to have some issues of that sort, > especially one scheduled during the summer. If we get to the point > where those patches are the only ones left, and the relevant people > still aren't back, I think we can just push them all to the next fest. > But I doubt we are moving fast enough to make that happen. I just got home last night, and am currently plowing through my pg mailing list queue. I should be able to make progress before the weekend is out. Joe -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org iQIcBAEBCAAGBQJKcdITAAoJEDfy90M199hle5cP/1AiepmKpBO0LONGzX3Lu0JW L/ilfv0Ea3L/YRksld9YjaVZgMjtMXhF/srHP2L1nyTylKTeFIfYLTwjAWz79bf3 S1yamofxSvfzYYLhRcTEHE6MXaQwrGJwkzkcgsHM2E8TJm4xdFOqIqsTUqI5ExOS PclWH1W8GWC8grJ4+kzN2kOEh5hQcdq+zZeFQP5C405TVjP+AQJu3uXR44VtlExL q1VOxICUwWiXldqCiFhE6AWX1RSWWhfoaP6lkVmySyn2QVyK2JFmuF8r1XUhE7qW H/Oya7NOz3aDjziNZc20ggW63KwjLxddeCE1kkuqnnNLNEeKcbPykcZUlVgfZevv 1X71KSPNw/eMtTItkGqSEIYW7LZ622uOT1VOC0ZZcKhSnDVh7KTloiGhjUVPYeCJ SqocXN6kR1qA2z6iAxuxIZE2yl8xMA9EGecVuxDdiO/SS9cgBAgD3gxSgzsoUt7F rL+IK25+dErynMzDcVK7ZJEvQd5m8YjMAKEPLzs6ELjlt9yA6E+P8c/Tx+nEvCEu Ac+ayVsklLx8fbg4PCFY+dD7nSDEqX/1yYtZdx+6T23vx6VcAAcTVwU/O/g5FGKw 7ovpL2ruL/Gx9X527Vs2hBHOWG4odtsFyIvsQz/ZsDNftIJ7kkCgitscE8KKF4ha Im4yCTz6hpF2CBfKyYSF =rcGM -----END PGP SIGNATURE-----