Обсуждение: contrib/xml2 and PG_MODULE_MAGIC

contrib/xml2 currently has PG_MODULE_MAGIC in xslt_proc.c, which
results in a runtime error on systems that built the module without
support for libxslt per the comments in the Makefile.  Should
PG_MODULE_MAGIC be in xpath.c instead?

-- 
Michael Fuhr

Michael Fuhr <mike@fuhr.org> writes:
> contrib/xml2 currently has PG_MODULE_MAGIC in xslt_proc.c, which
> results in a runtime error on systems that built the module without
> support for libxslt per the comments in the Makefile.  Should
> PG_MODULE_MAGIC be in xpath.c instead?

[ examines xml2/Makefile ... ]  Yeah, sure looks that way.  Will fix.

Even more interesting would be to fix things so that xml2 gets built as
part of the regular contrib build, but I'm not sure if we're ready to
add stuff to the configure script for the sole benefit of a contrib
module.  I'd be more willing to do it if there were a long-term plan for
putting libxml-dependent code into the core.  Do we have a roadmap yet
for XML development?  I thought there was a session at the anniversary
conference devoted to sketching one, but if anything came out of that
I missed it.
        regards, tom lane

Tom Lane wrote:
> Michael Fuhr <mike@fuhr.org> writes:
>   
>> contrib/xml2 currently has PG_MODULE_MAGIC in xslt_proc.c, which
>> results in a runtime error on systems that built the module without
>> support for libxslt per the comments in the Makefile.  Should
>> PG_MODULE_MAGIC be in xpath.c instead?
>>     
>
> [ examines xml2/Makefile ... ]  Yeah, sure looks that way.  Will fix.
>
> Even more interesting would be to fix things so that xml2 gets built as
> part of the regular contrib build, but I'm not sure if we're ready to
> add stuff to the configure script for the sole benefit of a contrib
> module.  I'd be more willing to do it if there were a long-term plan for
> putting libxml-dependent code into the core.  Do we have a roadmap yet
> for XML development?  I thought there was a session at the anniversary
> conference devoted to sketching one, but if anything came out of that
> I missed it.
>
>   


Me too.

Part of the trouble is that support for the standard will require 
support in the parser, so we need to decide if we want to go down that 
road. Personally I think we should, but it would make a significant 
change from what we have available now. Peter seemed a bit more 
ambivalent about it, though.

cheers

andrew

Tom Lane wrote:
> Even more interesting would be to fix things so that xml2 gets built
> as part of the regular contrib build, but I'm not sure if we're ready
> to add stuff to the configure script for the sole benefit of a
> contrib module.

It might be good to get the configury code out in this release for 
advance testing.

> I'd be more willing to do it if there were a 
> long-term plan for putting libxml-dependent code into the core.  Do
> we have a roadmap yet for XML development?  I thought there was a
> session at the anniversary conference devoted to sketching one, but
> if anything came out of that I missed it.

I put a write-up here: 
http://developer.postgresql.org/index.php/XML_Support

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

URL added to TODO list.

---------------------------------------------------------------------------

Peter Eisentraut wrote:
> Tom Lane wrote:
> > Even more interesting would be to fix things so that xml2 gets built
> > as part of the regular contrib build, but I'm not sure if we're ready
> > to add stuff to the configure script for the sole benefit of a
> > contrib module.
> 
> It might be good to get the configury code out in this release for 
> advance testing.
> 
> > I'd be more willing to do it if there were a 
> > long-term plan for putting libxml-dependent code into the core.  Do
> > we have a roadmap yet for XML development?  I thought there was a
> > session at the anniversary conference devoted to sketching one, but
> > if anything came out of that I missed it.
> 
> I put a write-up here: 
> http://developer.postgresql.org/index.php/XML_Support
> 
> -- 
> Peter Eisentraut
> http://developer.postgresql.org/~petere/
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo@postgresql.org so that your
>        message can get through to the mailing list cleanly

--  Bruce Momjian   bruce@momjian.us EnterpriseDB    http://www.enterprisedb.com
 + If your life is a hard drive, Christ can be your backup. +