Обсуждение: Re: [COMMITTERS] pgsql: Remove Christof Petig copyright on include file, per author

Bruce Momjian wrote:
> Log Message:
> -----------
> Remove Christof Petig copyright on include file, per author request.

Huh, I thought what he actually told was that the file was released
under BSD license.  Maybe I missed it, but I didn't see him asking to
remove the copyright.

We certainly have copyrights attributed to individual people.  Jan Wieck
has his name on the PL/Tcl and PL/pgSQL files, for example.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Remove Christof Petig copyright on include file, per author request.
> 
> Huh, I thought what he actually told was that the file was released
> under BSD license.  Maybe I missed it, but I didn't see him asking to
> remove the copyright.

Also, now that I see the actual diff, I see you only removed the
$PostgreSQL$ tag from ecpg_informix.h.  I assume this was unintended.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Remove Christof Petig copyright on include file, per author request.
> 
> Huh, I thought what he actually told was that the file was released
> under BSD license.  Maybe I missed it, but I didn't see him asking to
> remove the copyright.
> 
> We certainly have copyrights attributed to individual people.  Jan Wieck
> has his name on the PL/Tcl and PL/pgSQL files, for example.

We should not have individual copyrights to individuals in our source
tree.  If Jan's is in there, it should be removed too (with his
approval).  The only copyright holder should be PostgreSQL Global
Development Group.

Jan, would you fix that?

--  Bruce Momjian   http://candle.pha.pa.us SRA OSS, Inc.   http://www.sraoss.com
 + If your life is a hard drive, Christ can be your backup. +

Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove Christof Petig copyright on include file, per author request.
> > 
> > Huh, I thought what he actually told was that the file was released
> > under BSD license.  Maybe I missed it, but I didn't see him asking to
> > remove the copyright.
> 
> Also, now that I see the actual diff, I see you only removed the
> $PostgreSQL$ tag from ecpg_informix.h.  I assume this was unintended.
> 

Intended.  None of the other include files in that directory had it. 
Either all should, or none.  Should we add it to all of them?

--  Bruce Momjian   http://candle.pha.pa.us SRA OSS, Inc.   http://www.sraoss.com
 + If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:
> Alvaro Herrera wrote:
> > Bruce Momjian wrote:
> > > Log Message:
> > > -----------
> > > Remove Christof Petig copyright on include file, per author request.
> > 
> > Huh, I thought what he actually told was that the file was released
> > under BSD license.  Maybe I missed it, but I didn't see him asking to
> > remove the copyright.
> > 
> > We certainly have copyrights attributed to individual people.  Jan Wieck
> > has his name on the PL/Tcl and PL/pgSQL files, for example.
> 
> We should not have individual copyrights to individuals in our source
> tree.  If Jan's is in there, it should be removed too (with his
> approval).  The only copyright holder should be PostgreSQL Global
> Development Group.

Why give all our code to a organisation that doesn't exist?

On the $PostgreSQL$ issue, I think it's best to have the tag everywhere,
so if these files were the only ones that had it, I'd rather add them to
the rest ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Bruce Momjian <pgman@candle.pha.pa.us> writes:
> Intended.  None of the other include files in that directory had it. 
> Either all should, or none.  Should we add it to all of them?

All.  There's no good excuse for not having a version tag on every
source-code file.  The contrib stuff is pretty bad about this, but
hey, it's just contrib ;-).  ecpg is part of the main tree and it
ought to be up to project standards.
        regards, tom lane

On Wed, Mar 08, 2006 at 07:37:14PM -0300, Alvaro Herrera wrote:
> On the $PostgreSQL$ issue, I think it's best to have the tag everywhere,
> so if these files were the only ones that had it, I'd rather add them to
> the rest ...

+1. I'd also argue that it should be in contrib as well.

I can submit a patch for contrib or the entire tree if desired.
Convention is that it goes near the top of the file, correct?
-- 
Jim C. Nasby, Sr. Engineering Consultant      jnasby@pervasive.com
Pervasive Software      http://pervasive.com    work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf       cell: 512-569-9461

Jim C. Nasby wrote:

> +1. I'd also argue that it should be in contrib as well.
> 
> I can submit a patch for contrib or the entire tree if desired.
> Convention is that it goes near the top of the file, correct?

Correct.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

On Wed, Mar 08, 2006 at 11:27:23PM -0300, Alvaro Herrera wrote:
> Jim C. Nasby wrote:
> 
> > +1. I'd also argue that it should be in contrib as well.
> > 
> > I can submit a patch for contrib or the entire tree if desired.
> > Convention is that it goes near the top of the file, correct?
> 
> Correct.

K, I'll work on everything but contrib tonight.

What do people think about contrib? Yea or nay for enforcing
$PostgreSQL$?
-- 
Jim C. Nasby, Sr. Engineering Consultant      jnasby@pervasive.com
Pervasive Software      http://pervasive.com    work: 512-231-6117
vcard: http://jim.nasby.net/pervasive.vcf       cell: 512-569-9461

On Wed, 8 Mar 2006, Jim C. Nasby wrote:

> On Wed, Mar 08, 2006 at 11:27:23PM -0300, Alvaro Herrera wrote:
>> Jim C. Nasby wrote:
>>
>>> +1. I'd also argue that it should be in contrib as well.
>>>
>>> I can submit a patch for contrib or the entire tree if desired.
>>> Convention is that it goes near the top of the file, correct?
>>
>> Correct.
>
> K, I'll work on everything but contrib tonight.
>
> What do people think about contrib? Yea or nay for enforcing
> $PostgreSQL$?

Any code in our source tree should conform to the same version tagging, so 
Yah ...

----
Marc G. Fournier           Hub.Org Networking Services (http://www.hub.org)
Email: scrappy@hub.org           Yahoo!: yscrappy              ICQ: 7615664

"Jim C. Nasby" <jnasby@pervasive.com> writes:
> Convention is that it goes near the top of the file, correct?

It goes at the bottom of the file header block comment ... if there
isn't a block comment at the start of the file, there should be.  We
have a thousand or so examples to follow ;-)
        regards, tom lane

On Wed, Mar 08, 2006 at 05:31:47PM -0500, Bruce Momjian wrote:
> We should not have individual copyrights to individuals in our source
> tree.  If Jan's is in there, it should be removed too (with his
> approval).  The only copyright holder should be PostgreSQL Global
> Development Group.

Err, to do that someone would need to collect copyright assignments (ie
signed documents) from every single contributer, including people no
longer associated with the project. That is something you can do if you
start doing it when the project starts but it way too late for that
now.

Have a nice day,
--
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

Martijn van Oosterhout <kleptog@svana.org> writes:
> On Wed, Mar 08, 2006 at 05:31:47PM -0500, Bruce Momjian wrote:
>> The only copyright holder should be PostgreSQL Global
>> Development Group.

> Err, to do that someone would need to collect copyright assignments (ie
> signed documents) from every single contributer, including people no
> longer associated with the project. That is something you can do if you
> start doing it when the project starts but it way too late for that
> now.

Not for copyrights in the name of people who are still around, which is
99% of the issue.
        regards, tom lane

On 3/8/2006 5:31 PM, Bruce Momjian wrote:
> Alvaro Herrera wrote:
>> Bruce Momjian wrote:
>> > Log Message:
>> > -----------
>> > Remove Christof Petig copyright on include file, per author request.
>> 
>> Huh, I thought what he actually told was that the file was released
>> under BSD license.  Maybe I missed it, but I didn't see him asking to
>> remove the copyright.
>> 
>> We certainly have copyrights attributed to individual people.  Jan Wieck
>> has his name on the PL/Tcl and PL/pgSQL files, for example.
> 
> We should not have individual copyrights to individuals in our source
> tree.  If Jan's is in there, it should be removed too (with his
> approval).  The only copyright holder should be PostgreSQL Global
> Development Group.
> 
> Jan, would you fix that?

We've been there before, and not only once. I wonder why we still find 
more of these, because every time it comes up I agree to removal of it.


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

Jan Wieck wrote:
> On 3/8/2006 5:31 PM, Bruce Momjian wrote:
> > Alvaro Herrera wrote:
> >> Bruce Momjian wrote:
> >> > Log Message:
> >> > -----------
> >> > Remove Christof Petig copyright on include file, per author request.
> >> 
> >> Huh, I thought what he actually told was that the file was released
> >> under BSD license.  Maybe I missed it, but I didn't see him asking to
> >> remove the copyright.
> >> 
> >> We certainly have copyrights attributed to individual people.  Jan Wieck
> >> has his name on the PL/Tcl and PL/pgSQL files, for example.
> > 
> > We should not have individual copyrights to individuals in our source
> > tree.  If Jan's is in there, it should be removed too (with his
> > approval).  The only copyright holder should be PostgreSQL Global
> > Development Group.
> > 
> > Jan, would you fix that?
> 
> We've been there before, and not only once. I wonder why we still find 
> more of these, because every time it comes up I agree to removal of it.

Perhaps your name reproduces somehow.  :-)

--  Bruce Momjian   http://candle.pha.pa.us SRA OSS, Inc.   http://www.sraoss.com
 + If your life is a hard drive, Christ can be your backup. +

On 3/10/2006 10:53 AM, Bruce Momjian wrote:

> Jan Wieck wrote:
>> On 3/8/2006 5:31 PM, Bruce Momjian wrote:
>> > Alvaro Herrera wrote:
>> >> Bruce Momjian wrote:
>> >> > Log Message:
>> >> > -----------
>> >> > Remove Christof Petig copyright on include file, per author request.
>> >> 
>> >> Huh, I thought what he actually told was that the file was released
>> >> under BSD license.  Maybe I missed it, but I didn't see him asking to
>> >> remove the copyright.
>> >> 
>> >> We certainly have copyrights attributed to individual people.  Jan Wieck
>> >> has his name on the PL/Tcl and PL/pgSQL files, for example.
>> > 
>> > We should not have individual copyrights to individuals in our source
>> > tree.  If Jan's is in there, it should be removed too (with his
>> > approval).  The only copyright holder should be PostgreSQL Global
>> > Development Group.
>> > 
>> > Jan, would you fix that?
>> 
>> We've been there before, and not only once. I wonder why we still find 
>> more of these, because every time it comes up I agree to removal of it.
> 
> Perhaps your name reproduces somehow.  :-)

Scary to see it plastered all over the place.


Jan

-- 
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me.                                  #
#================================================== JanWieck@Yahoo.com #

On Friday 10 March 2006 07:53, Bruce Momjian wrote:
> Jan Wieck wrote:
> > On 3/8/2006 5:31 PM, Bruce Momjian wrote:
> > > Alvaro Herrera wrote:
> > >> Bruce Momjian wrote:
> > >> > Log Message:
> > >> > -----------
> > >> > Remove Christof Petig copyright on include file, per author request.
> > >>
> > >> Huh, I thought what he actually told was that the file was released
> > >> under BSD license.  Maybe I missed it, but I didn't see him asking to
> > >> remove the copyright.
> > >>
> > >> We certainly have copyrights attributed to individual people.  Jan
> > >> Wieck has his name on the PL/Tcl and PL/pgSQL files, for example.
> > >
> > > We should not have individual copyrights to individuals in our source
> > > tree.  If Jan's is in there, it should be removed too (with his
> > > approval).  The only copyright holder should be PostgreSQL Global
> > > Development Group.
> > >
> > > Jan, would you fix that?
> >
> > We've been there before, and not only once. I wonder why we still find
> > more of these, because every time it comes up I agree to removal of it.
>
> Perhaps your name reproduces somehow.  :-)

That pesky replication daemon... ;-)

-- 
Darcy Buskermolen
Wavefire Technologies Corp.

http://www.wavefire.com
ph: 250.717.0200
fx: 250.763.1759

In an attempt to throw the authorities off his trail, pgman@candle.pha.pa.us (Bruce Momjian) transmitted:
> Jan Wieck wrote:
>> We've been there before, and not only once. I wonder why we still find 
>> more of these, because every time it comes up I agree to removal of it.
>
> Perhaps your name reproduces somehow.  :-)

I think the word you wanted was "replicates"  :-).
-- 
select 'cbbrowne' || '@' || 'gmail.com';
http://linuxdatabases.info/info/
We are in fact well and truly doomed.
-- Jamie Zawinski http://www.jwz.org/gruntle/nscpdorm.html