Обсуждение: pg_dump doesn't dump conversions?
Is it just me or does pg_dump have no support for dumping conversions at all? conversions=# CREATE CONVERSION myconv FOR 'UNICODE' TO 'LATIN1' FROM alt_to_iso; CREATE CONVERSION conversions=# \q bash-2.05a$ /home/chriskl/local/bin/pg_dump conversions -- -- PostgreSQL database dump -- SET SESSION AUTHORIZATION 'chriskl'; -- -- TOC entry 3 (OID 2200) -- Name: public; Type: ACL; Schema: -; Owner: chriskl -- REVOKE ALL ON SCHEMA public FROM PUBLIC; GRANT ALL ON SCHEMA public TO PUBLIC; -- -- TOC entry 2 (OID 2200) -- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: chriskl -- COMMENT ON SCHEMA public IS 'Standard public schema';
Just to emphasise how bad this is, the strings 'CONVERSION' and 'pg_conversion' do not appear anywhere in the pg_dump source code. I'm not putting up my hand to implement it that quickly this close to release, but it's a thing that should probably be back ported to 7.3, as people will be unable to dump their conversions. Chris Christopher Kings-Lynne wrote: > Is it just me or does pg_dump have no support for dumping conversions at > all? > > conversions=# CREATE CONVERSION myconv FOR 'UNICODE' TO 'LATIN1' FROM > alt_to_iso; > CREATE CONVERSION > conversions=# \q > > bash-2.05a$ /home/chriskl/local/bin/pg_dump conversions > -- > -- PostgreSQL database dump > -- > > SET SESSION AUTHORIZATION 'chriskl'; > > -- > -- TOC entry 3 (OID 2200) > -- Name: public; Type: ACL; Schema: -; Owner: chriskl > -- > > REVOKE ALL ON SCHEMA public FROM PUBLIC; > GRANT ALL ON SCHEMA public TO PUBLIC; > > > -- > -- TOC entry 2 (OID 2200) > -- Name: SCHEMA public; Type: COMMENT; Schema: -; Owner: chriskl > -- > > COMMENT ON SCHEMA public IS 'Standard public schema'; > > > > ---------------------------(end of broadcast)--------------------------- > TIP 3: if posting/reading through Usenet, please send an appropriate > subscribe-nomail command to majordomo@postgresql.org so that your > message can get through to the mailing list cleanly
Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> I'm not putting up my hand to implement it that quickly this close to
> release, but it's a thing that should probably be back ported to 7.3, as
> people will be unable to dump their conversions.
Which people would those be, exactly? I doubt that very many people
have created their own conversions. I agree that this should be fixed
in the long run, but I'm having a hard time grading it as a critical
issue ...
regards, tom lane
>>I'm not putting up my hand to implement it that quickly this close to >>release, but it's a thing that should probably be back ported to 7.3, as >>people will be unable to dump their conversions. > > > Which people would those be, exactly? I doubt that very many people > have created their own conversions. I agree that this should be fixed > in the long run, but I'm having a hard time grading it as a critical > issue ... Surely it should be really important for us to actually dump what people have in their database and also the integrity of their dumps? I'll accept that it's not important enough for a back port in that case? Chris
Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
>> Which people would those be, exactly? I doubt that very many people
>> have created their own conversions. I agree that this should be fixed
>> in the long run, but I'm having a hard time grading it as a critical
>> issue ...
> Surely it should be really important for us to actually dump what people
> have in their database and also the integrity of their dumps?
Let me put it this way: it is vastly more important to fix pg_dump's
object-ordering problems than to fix its ignorance of conversions.
We are not fixing the former for 7.4, and we wouldn't try to backport
any fix that might appear for 7.5 into 7.4 either. Conversions won't
get a higher priority.
regards, tom lane
> Let me put it this way: it is vastly more important to fix pg_dump's > object-ordering problems than to fix its ignorance of conversions. > We are not fixing the former for 7.4, and we wouldn't try to backport > any fix that might appear for 7.5 into 7.4 either. Conversions won't > get a higher priority. OK, your call. TODO item Bruce? May as well assign it to me - i'm working on pg_dump at the moment. Chris
Christopher Kings-Lynne wrote: > > Let me put it this way: it is vastly more important to fix pg_dump's > > object-ordering problems than to fix its ignorance of conversions. > > We are not fixing the former for 7.4, and we wouldn't try to backport > > any fix that might appear for 7.5 into 7.4 either. Conversions won't > > get a higher priority. > > OK, your call. TODO item Bruce? May as well assign it to me - i'm > working on pg_dump at the moment. Added to TODO: * Allow pg_dump to dump CREATE CONVERSION (Christopher) -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001+ If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania19073