Обсуждение: AW: Modified pg_dump & new pg_restore need testing...

Поиск
Список
Период
Сортировка

AW: Modified pg_dump & new pg_restore need testing...

От
Zeugswetter Andreas SB
Дата:
> > As suggested I have now added a '--plain-text, -p' option to pg_dump
> > to dump it into text.
> 
> The *default* action of pg_dump should be to write plain text and to
> standard output. Changing that will certainly make a lot of 
> people very unhappy.

Imho the default should be text for anything except data. The data should
imho 
be in a format similar to a binary cursor. I say similar, because this
format should 
probably be converted to a network byte order, so you can restore on another
hardware. Imho calling type output and input functions during backup/restore
is a substantial overhead that would best be avoided.

I agree, that the output should not be compressed by default.

Andreas


Re: AW: Modified pg_dump & new pg_restore need testing...

От
Tom Lane
Дата:
Zeugswetter Andreas SB <ZeugswetterA@wien.spardat.at> writes:
> Imho the default should be text for anything except data. The data
> should imho be in a format similar to a binary cursor. I say similar,
> because this format should probably be converted to a network byte
> order, so you can restore on another hardware. Imho calling type
> output and input functions during backup/restore is a substantial
> overhead that would best be avoided.

I think this would be an extremely *bad* idea.  One of the principal
functions of pg_dump is to provide a portable representation of data;
that is, portable across machines and across Postgres versions (where
the internal representation of data may change!).

Not only should binary data representation not be the default, IMHO
we shouldn't offer it as an option either.  Otherwise dbadmins will
promptly shoot themselves in the foot with it.  Do you want to field
the support calls saying "help, I already blew away my 7.n installation
but 7.n+1 won't read my pg_dump backup"?
        regards, tom lane