Обсуждение: Re: [HACKERS] Re: [PATCHES] COMMENT ON patch

--- Byron Nikolaidis <byron.nikolaidis@home.com> wrote:
...
> > I still need to write the SGML and change pg_dump to
> > generate COMMENT ON statements, and also regression tests,
> > but the functionality should be complete. Just glancing
> > over the Win32 ODBC driver, it appears that SQLTables() and
> > SQLColumns() is not currently fetching the associated
> > description from pg_description for the REMARKS parameter
> > to the call. Perhaps this could be changed?
> 
> It wouldn't be hard to add the pg_description to the remarks.
> Does this field exist for all previous postgres releases (specifically,
> 6.2,6.3, and 6.4) ??
> 
> Byron
...

It appears, just from a spot check of the initial database structure
created from old RPMS on rpmfind.net that pg_description was added
after 6.2 whose "provides" looks like this (for 6.2.1):

...
/var/lib/postgresql/data/base/template1/pg_attrdefind
/var/lib/postgresql/data/base/template1/pg_attrelidind
/var/lib/postgresql/data/base/template1/pg_attribute
/var/lib/postgresql/data/base/template1/pg_class
/var/lib/postgresql/data/base/template1/pg_classnameind
/var/lib/postgresql/data/base/template1/pg_classoidind
/var/lib/postgresql/data/base/template1/pg_index
/var/lib/postgresql/data/base/template1/pg_inheritproc
/var/lib/postgresql/data/base/template1/pg_inherits
/var/lib/postgresql/data/base/template1/pg_internal.init
...

while for 6.3.1, the initial database structure looks like:

...
/var/lib/pgsql/base/template1/pg_class
/var/lib/pgsql/base/template1/pg_class_oid_index
/var/lib/pgsql/base/template1/pg_class_relname_index
/var/lib/pgsql/base/template1/pg_description
/var/lib/pgsql/base/template1/pg_description_objoid_index
/var/lib/pgsql/base/template1/pg_index
/var/lib/pgsql/base/template1/pg_inheritproc
...

And of course, it appears also in 6.4.x, so I assume that it was added 
between the 6.2 and 6.3 releases. Is that going to be a problem?

Hope that helps,

Mike Mascari
(mascarim@yahoo.com)










__________________________________________________
Do You Yahoo!?
Bid and sell for free at http://auctions.yahoo.com

Mike Mascari <mascarim@yahoo.com> writes:
>> Does this field exist for all previous postgres releases (specifically,
>> 6.2,6.3, and 6.4) ??

> And of course, it appears also in 6.4.x, so I assume that it was added 
> between the 6.2 and 6.3 releases. Is that going to be a problem?

For Peter's purposes, it's unnecessary to worry about anything older
than 6.4, since he's depending on an up-to-date libpq and current libpq
won't talk to anything older than 6.4.

Byron might still care about 6.2 ... I dunno whether ODBC currently
really works with 6.2 or not, or whether it needs to keep doing so.
        regards, tom lane

Tom Lane wrote:
> 
> Mike Mascari <mascarim@yahoo.com> writes:
> >> Does this field exist for all previous postgres releases (specifically,
> >> 6.2,6.3, and 6.4) ??
> 
> > And of course, it appears also in 6.4.x, so I assume that it was added
> > between the 6.2 and 6.3 releases. Is that going to be a problem?
> 
> For Peter's purposes, it's unnecessary to worry about anything older
> than 6.4, since he's depending on an up-to-date libpq and current libpq
> won't talk to anything older than 6.4.
> 
> Byron might still care about 6.2 ... I dunno whether ODBC currently
> really works with 6.2 or not, or whether it needs to keep doing so.
> 
>                         regards, tom lane


It still really works with 6.2!   But whether it needs to, is another
question!

I'm not sure if anyone cares if it works with 6.2 (even 6.3 for that
matter) or not.

Byron

> --- Byron Nikolaidis <byron.nikolaidis@home.com> wrote:
> ...
> > > I still need to write the SGML and change pg_dump to
> > > generate COMMENT ON statements, and also regression tests,
> > > but the functionality should be complete. Just glancing
> > > over the Win32 ODBC driver, it appears that SQLTables() and
> > > SQLColumns() is not currently fetching the associated
> > > description from pg_description for the REMARKS parameter
> > > to the call. Perhaps this could be changed?
> > 
> > It wouldn't be hard to add the pg_description to the remarks.
> > Does this field exist for all previous postgres releases (specifically,
> > 6.2,6.3, and 6.4) ??

HISTORY file says added in release 6.3.


--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026