Обсуждение: Re: commits

Bruce Momjian <maillist@candle.pha.pa.us> writes:
> Do you want to be making these commits now?  We haven't split the tree,
> so they will appear in 6.5.x.

Yeah, I know.  I'm in bugfix mode: CASE does not work in any context
involving GROUP BY or aggregates, egselect coalesce(f1,0) from int4_tbl group by f1;ERROR:  Illegal use of aggregates
ornon-group column in target list
 
Since we now support CASE "officially", I think this is important
enough to fix in 6.5.*.  The cause is that parse_agg.c's routines
neglected the CaseExpr nodetype case.  I couldn't quite stomach
adding the same boilerplate code to yet another place, so I decided
to start implementing the suggestion I made a while ago to create
centralized tree-recursion logic.
        regards, tom lane

> Bruce Momjian <maillist@candle.pha.pa.us> writes:
> > Do you want to be making these commits now?  We haven't split the tree,
> > so they will appear in 6.5.x.
> 
> Yeah, I know.  I'm in bugfix mode: CASE does not work in any context
> involving GROUP BY or aggregates, eg
>     select coalesce(f1,0) from int4_tbl group by f1;
>     ERROR:  Illegal use of aggregates or non-group column in target list
> Since we now support CASE "officially", I think this is important
> enough to fix in 6.5.*.  The cause is that parse_agg.c's routines
> neglected the CaseExpr nodetype case.  I couldn't quite stomach
> adding the same boilerplate code to yet another place, so I decided
> to start implementing the suggestion I made a while ago to create
> centralized tree-recursion logic.

Oh, OK.  Just checking.  People sometimes forget.  Thomas was _really_
confused.

I certainly would like to see that stuff centralized.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026
 

> Thomas was _really_ confused.

Maybe. But how did you know? And about what??
                  - Thomas

-- 
Thomas Lockhart                lockhart@alumni.caltech.edu
South Pasadena, California

> > Thomas was _really_ confused.
> 
> Maybe. But how did you know? And about what??

I thought you were confused about the optimizer geometric fixes Tom
made.  I shouldn't have assumed you were confused.  Sorry.

--  Bruce Momjian                        |  http://www.op.net/~candle maillist@candle.pha.pa.us            |  (610)
853-3000+  If your life is a hard drive,     |  830 Blythe Avenue +  Christ can be your backup.        |  Drexel Hill,
Pennsylvania19026