Обсуждение: TCL/TK library glitches in configure.in
The configure script is not correctly substituting the TCL/TK
libraries it finds. Please remember that setting variables in the
configure script is not enough to get them substituted into Makefiles
and such.
Please apply the following patch and rerun autoconf.
Cheers,
Brook
===========================================================================
--- configure.in.orig Mon Oct 12 01:00:20 1998
+++ configure.in Mon Oct 12 11:08:29 1998
@@ -800,6 +800,7 @@
USE_TCL=
else
TCL_LIB=-l$TCL_LIB
+ AC_SUBST(TCL_LIB)
fi
fi
@@ -883,6 +884,7 @@
USE_TCL=
else
TK_LIB=-l$TK_LIB
+ AC_SUBST(TK_LIB)
fi
LIBS="$ice_save_LIBS"
>
> The configure script is not correctly substituting the TCL/TK
> libraries it finds. Please remember that setting variables in the
> configure script is not enough to get them substituted into Makefiles
> and such.
>
> Please apply the following patch and rerun autoconf.
The funny thing is that commenting out TCL_LIB and TK_LIB
from Makefile.global works too (even --with-tcl).
>
> Cheers,
> Brook
>
Jan
--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#======================================== jwieck@debis.com (Jan Wieck) #
I have removed the mention of TCL_LIB from Makefile.global. The new code looks in tcconfig.sh, and gets the values there. I just fixed it today. Please check for the commented out entries in Makefile.global and test it to see if it works. Seems to work here. However, I will apply the patch and remove the Makefile.global comments of TCL_LIB, just so we can keep it around. I think Billy is working on removal of that hole section. Thanks. > The configure script is not correctly substituting the TCL/TK > libraries it finds. Please remember that setting variables in the > configure script is not enough to get them substituted into Makefiles > and such. > > Please apply the following patch and rerun autoconf. > > Cheers, > Brook > > =========================================================================== > --- configure.in.orig Mon Oct 12 01:00:20 1998 > +++ configure.in Mon Oct 12 11:08:29 1998 > @@ -800,6 +800,7 @@ > USE_TCL= > else > TCL_LIB=-l$TCL_LIB > + AC_SUBST(TCL_LIB) > fi > fi > > @@ -883,6 +884,7 @@ > USE_TCL= > else > TK_LIB=-l$TK_LIB > + AC_SUBST(TK_LIB) > fi > > LIBS="$ice_save_LIBS" > > -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> > > > The configure script is not correctly substituting the TCL/TK > > libraries it finds. Please remember that setting variables in the > > configure script is not enough to get them substituted into Makefiles > > and such. > > > > Please apply the following patch and rerun autoconf. > > The funny thing is that commenting out TCL_LIB and TK_LIB > from Makefile.global works too (even --with-tcl). Yes, this is Billy's fix of yesterday, by using tclconfig.sh. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> > > > > > The configure script is not correctly substituting the TCL/TK > > > libraries it finds. Please remember that setting variables in the > > > configure script is not enough to get them substituted into Makefiles > > > and such. > > > > > > Please apply the following patch and rerun autoconf. > > > > The funny thing is that commenting out TCL_LIB and TK_LIB > > from Makefile.global works too (even --with-tcl). > > Yes, this is Billy's fix of yesterday, by using tclconfig.sh. Sigh... I REALLY must not make patches in the wee hours of the morning. I forgot to copy the original Makefile.global.in to Makefile.global.in.orig before I removed the references to TCL_LIB and TK_LIB. Hence the changes did not make it into the patch. My most humble apologies. -- ____ | Billy G. Allie | Domain....: Bill.Allie@mug.org | /| | 7436 Hartwell | Compuserve: 76337,2061 |-/-|----- | Dearborn, MI 48126| MSN.......: B_G_Allie@email.msn.com |/ |LLIE | (313) 582-1540 |
>
> I have removed the mention of TCL_LIB from Makefile.global. The new
> code looks in tcconfig.sh, and gets the values there. I just fixed it
> today. Please check for the commented out entries in Makefile.global
> and test it to see if it works. Seems to work here.
>
> However, I will apply the patch and remove the Makefile.global comments
> of TCL_LIB, just so we can keep it around. I think Billy is working on
> removal of that hole section.
>
> Thanks.
>
Checked out at Oct. 13 09:52 MET DST (it's +0200 so should be
03:52 in your TZ), configured with switches --enable-shared
and --with-tcl.
Compiled clean and regression went through without a single
'failed'.
Linux i486 ELF 2.1.88
BTW: You still mention the rewrite system on the todo list.
What was left where replacing some functions (OffsetVarNodes
and the like) by the new versions that are now static in the
rewriteHandler.
But the old versions are used by the parser somewhere and I'm
not totally sure if switching there to use the new ones would
have any side effects.
Things are stable now and working for what we currently have.
I'll not touch the rewrite system (except for bugs) again
before 6.4 is released. Please close the item.
When we go on and develop for 6.5 I think we will work on
more capabilities in the parser/planner (e.g. subselects in
the targetlist, outer joins etc.). This will require
additions in the rewrite system and then it's time to get on
it again.
Jan
--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#======================================== jwieck@debis.com (Jan Wieck) #
> > > > I have removed the mention of TCL_LIB from Makefile.global. The new > > code looks in tcconfig.sh, and gets the values there. I just fixed it > > today. Please check for the commented out entries in Makefile.global > > and test it to see if it works. Seems to work here. > > > > However, I will apply the patch and remove the Makefile.global comments > > of TCL_LIB, just so we can keep it around. I think Billy is working on > > removal of that hole section. > > > > Thanks. > > > > Checked out at Oct. 13 09:52 MET DST (it's +0200 so should be > 03:52 in your TZ), configured with switches --enable-shared > and --with-tcl. Cool. I think with Billy's help, we can remove the while tcl testing section from configure.in, at least the part that was bound to specific tcl/tk directories and version numbers. > > Compiled clean and regression went through without a single > 'failed'. > > Linux i486 ELF 2.1.88 > > BTW: You still mention the rewrite system on the todo list. > What was left where replacing some functions (OffsetVarNodes > and the like) by the new versions that are now static in the > rewriteHandler. > > But the old versions are used by the parser somewhere and I'm > not totally sure if switching there to use the new ones would > have any side effects. > > Things are stable now and working for what we currently have. > I'll not touch the rewrite system (except for bugs) again > before 6.4 is released. Please close the item. OK, this is all I was waiting for. I suspected that was the case, but needed to hear it from you. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026
> Sigh... > > I REALLY must not make patches in the wee hours of the morning. I forgot to > copy the original Makefile.global.in to Makefile.global.in.orig before I > removed the references to TCL_LIB and TK_LIB. Hence the changes did not make > it into the patch. > > My most humble apologies. I had done the same thing, and only removed the defines in Makefile.global.in yesterday. -- Bruce Momjian | http://www.op.net/~candle maillist@candle.pha.pa.us | (610) 853-3000 + If your life is a hard drive, | 830 Blythe Avenue + Christ can be your backup. | Drexel Hill, Pennsylvania 19026