Further improvements to c8f621c43.
Coverity and inspection for the issue addressed in fd45d16f found some
questionable code.
Specifically coverity noticed that the wrong length was added in
ReorderBufferSerializeChange() - without immediate negative consequences
as the variable isn't used afterwards. During code-review and testing I
noticed that a bit of space was wasted when allocating tuple bufs in
several places. Thirdly, the debug memset()s in
ReorderBufferGetTupleBuf() reduce the error checking valgrind can do.
Backpatch: 9.4, like c8f621c43.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/e3e84fd35838a43feef94ea78534713d745e9a08
Modified Files
--------------
src/backend/replication/logical/decode.c | 24 +++++++++++++++---------
src/backend/replication/logical/reorderbuffer.c | 3 +++
2 files changed, 18 insertions(+), 9 deletions(-)