Fix possible internal overflow in numeric multiplication.
mul_var() postpones propagating carries until it risks overflow in its
internal digit array. However, the logic failed to account for the
possibility of overflow in the carry propagation step, allowing wrong
results to be generated in corner cases. We must slightly reduce the
when-to-propagate-carries threshold to avoid that.
Discovered and fixed by Dean Rasheed, with small adjustments by me.
This has been wrong since commit d72f6c75038d8d37e64a29a04b911f728044d83b,
so back-patch to all supported branches.
Branch
------
REL9_4_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/fa9fc3a1b8069c0ab5edcd6f8b0caf679fed9392
Modified Files
--------------
src/backend/utils/adt/numeric.c | 14 ++++++++++----
src/test/regress/expected/numeric.out | 27 +++++++++++++++++++++++++++
src/test/regress/sql/numeric.sql | 12 ++++++++++++
3 files changed, 49 insertions(+), 4 deletions(-)