Assorted code review for recent ProcArrayLock patch.
Post-commit review by Andres Freund discovered a couple of concurrency
bugs in the original patch: specifically, if the leader cleared a
follower's XID before it reached PGSemaphoreLock, the semaphore would be
left in the wrong state; and if another process did PGSemaphoreUnlock
for some unrelated reason, we might resume execution before the fact
that our XID was cleared was globally visible.
Also, improve the wording of some comments, rename nextClearXidElem
to firstClearXidElem in PROC_HDR for clarity, and drop some volatile
qualifiers that aren't necessary.
Amit Kapila, reviewed and slightly revised by me.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/4aec49899e5782247e134f94ce1c6ee926f88e1c
Modified Files
--------------
src/backend/storage/ipc/procarray.c | 41 +++++++++++++++++++++++++----------
src/backend/storage/lmgr/proc.c | 3 ++-
src/include/storage/proc.h | 5 +++--
3 files changed, 34 insertions(+), 15 deletions(-)