Обсуждение: pgsql: Fix typos in comments
Fix typos in comments Dmitriy Olshevskiy Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/3b075e9d7be0181f8434e7b24007d87b618934c0 Modified Files -------------- contrib/tsm_system_time/tsm_system_time.c | 2 +- doc/src/sgml/logicaldecoding.sgml | 2 +- doc/src/sgml/ref/pg_dumpall.sgml | 2 +- src/backend/access/gin/ginpostinglist.c | 14 +++++++------- src/backend/access/heap/heapam.c | 2 +- src/backend/access/nbtree/README | 2 +- src/backend/access/transam/xact.c | 4 ++-- src/backend/replication/logical/snapbuild.c | 2 +- src/backend/tsearch/dict_synonym.c | 2 +- src/backend/utils/adt/jsonfuncs.c | 2 +- src/test/regress/expected/event_trigger.out | 2 +- src/test/regress/sql/event_trigger.sql | 2 +- 12 files changed, 19 insertions(+), 19 deletions(-)
Magnus Hagander <magnus@hagander.net> writes: > Fix typos in comments This change is wrong and should be reverted: --- a/doc/src/sgml/ref/pg_dumpall.sgml +++ b/doc/src/sgml/ref/pg_dumpall.sgml @@ -454,7 +454,7 @@ PostgreSQL documentation <term><option>--database=<replaceable>dbname</replaceable></option></term> <listitem> <para> - Specifies the name of the database to connect to to dump global + Specifies the name of the database to connect to dump global objects and discover what other databases should be dumped. If not specified, the <literal>postgres</literal> database will be used, and if that does not exist, <literal>template1</literal> will be used. Or maybe we should rewrite the sentence to avoid the repeated "to". But right now it's grammatically incorrect. regards, tom lane
I wrote: > This change is wrong and should be reverted: > <para> > - Specifies the name of the database to connect to to dump global > + Specifies the name of the database to connect to dump global > objects and discover what other databases should be dumped. If > Or maybe we should rewrite the sentence to avoid the repeated "to". A little while later it came to me that we could write it like this: Specifies the name of the database to connect to for dumping global objects and discovering what other databases should be dumped. regards, tom lane
On Sun, May 17, 2015 at 5:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
I wrote:
> This change is wrong and should be reverted:
> <para>
> - Specifies the name of the database to connect to to dump global
> + Specifies the name of the database to connect to dump global
> objects and discover what other databases should be dumped. If
> Or maybe we should rewrite the sentence to avoid the repeated "to".
A little while later it came to me that we could write it like this:
Specifies the name of the database to connect to for dumping global
objects and discovering what other databases should be dumped.
That seems better, thanks. Fix applied.