Обсуждение: pgsql: Fix portability issue in pg_audit.

Поиск
Список
Период
Сортировка

pgsql: Fix portability issue in pg_audit.

От
Tom Lane
Дата:
Fix portability issue in pg_audit.

"%ld" is not a portable way to print int64's.  This may explain the
buildfarm crashes we're seeing --- it seems to make dromedary happy,
at least.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/35a1e1d1593f4355c9d87bbc8208a8736801a607

Modified Files
--------------
contrib/pg_audit/pg_audit.c |   35 ++++++++++++++++++++---------------
1 file changed, 20 insertions(+), 15 deletions(-)


Re: pgsql: Fix portability issue in pg_audit.

От
Alvaro Herrera
Дата:
Tom Lane wrote:
> Fix portability issue in pg_audit.
>
> "%ld" is not a portable way to print int64's.  This may explain the
> buildfarm crashes we're seeing --- it seems to make dromedary happy,
> at least.

FWIW you could use %zd for translatability, assuming we ever get
pg_audit translatable.

--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Re: pgsql: Fix portability issue in pg_audit.

От
Tom Lane
Дата:
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> "%ld" is not a portable way to print int64's.  This may explain the
>> buildfarm crashes we're seeing --- it seems to make dromedary happy,
>> at least.

> FWIW you could use %zd for translatability, assuming we ever get
> pg_audit translatable.

Really?  z means size_t.

            regards, tom lane