Обсуждение: pgsql: Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd

Поиск
Список
Период
Сортировка

pgsql: Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd

От
Tom Lane
Дата:
Fix minor bugs in commit 30bf4689a96cd283af33edcdd6b7210df3f20cd8 et al.

Coverity complained that the "else" added to fillPGconn() was unreachable,
which it was.  Remove the dead code.  In passing, rearrange the tests so as
not to bother trying to fetch values for options that can't be assigned.

Pre-9.3 did not have that issue, but it did have a "return" that should be
"goto oom_error" to ensure that a suitable error message gets filled in.

Branch
------
REL9_1_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/c2be18c333bc09bae27d6a518677232d6dbcb45d

Modified Files
--------------
src/interfaces/libpq/fe-connect.c |    3 +--
1 file changed, 1 insertion(+), 2 deletions(-)