Обсуждение: pgsql: Message improvements
Message improvements Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/8339f33d68e08d24eb316971a0ac73af162d52b3 Modified Files -------------- src/backend/libpq/auth.c | 2 +- src/backend/replication/logical/logical.c | 4 ++-- src/backend/replication/logical/reorderbuffer.c | 2 +- src/backend/replication/logical/snapbuild.c | 17 +++++++++++------ src/backend/replication/slot.c | 6 ++---- src/backend/utils/misc/guc.c | 14 +++++++------- 6 files changed, 24 insertions(+), 21 deletions(-)
A couple of minor observations: The new wording for this one seems worse off: > incomplete read from reorderbuffer spill file: read %d instead of %u bytes The "incomplete" aspect seems to be material...the proposed wording leads one to believe the file is unreadable for some reason and then goes on to say that bytes were read. how about: incomplete read of reorderbuffer spill file: read %d of expected %u bytes > Writes full pages to WAL when first modified after a checkpoint, even for > a non-critical modifications. "... even for non-critical modifications." -- drop the "a" since modifications is plural (or make it singular) David J. -- View this message in context: http://postgresql.nabble.com/pgsql-Message-improvements-tp5826611p5826612.html Sent from the PostgreSQL - committers mailing list archive at Nabble.com.