Обсуждение: pgsql: docs: Improve documentation of \pset without arguments.
docs: Improve documentation of \pset without arguments. The syntax summary previously failed to clarify that the first argument is also optional. The textual description did mention it, but all the way at the bottom. It fits better with the command overview, so move it there, and fix the summary also. Dilip Kumar, reviewed by Fabien Coelho Branch ------ master Details ------- http://git.postgresql.org/pg/commitdiff/967a4e7f3107e3c5b732fe4f8e13a1f31a255e46 Modified Files -------------- doc/src/sgml/ref/psql-ref.sgml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
On Thu, Jul 24, 2014 at 9:12 PM, Robert Haas <rhaas@postgresql.org> wrote: > docs: Improve documentation of \pset without arguments. > > The syntax summary previously failed to clarify that the first > argument is also optional. The textual description did mention it, > but all the way at the bottom. It fits better with the command > overview, so move it there, and fix the summary also. Is it better to back-patch this to 9.4? The first argument of \pset command is optional also in 9.4. This commit is in next CF with "Ready for Committer". Probably it needs to be marked as "Committed". Regards, -- Fujii Masao
On Sun, Aug 10, 2014 at 12:55 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Thu, Jul 24, 2014 at 9:12 PM, Robert Haas <rhaas@postgresql.org> wrote: >> docs: Improve documentation of \pset without arguments. >> >> The syntax summary previously failed to clarify that the first >> argument is also optional. The textual description did mention it, >> but all the way at the bottom. It fits better with the command >> overview, so move it there, and fix the summary also. > > Is it better to back-patch this to 9.4? The first argument of > \pset command is optional also in 9.4. I didn't feel it necessary, but if you want to, it's OK with me. > This commit is in next CF with "Ready for Committer". > Probably it needs to be marked as "Committed". Done. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On Mon, Aug 11, 2014 at 6:34 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Sun, Aug 10, 2014 at 12:55 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >> On Thu, Jul 24, 2014 at 9:12 PM, Robert Haas <rhaas@postgresql.org> wrote: >>> docs: Improve documentation of \pset without arguments. >>> >>> The syntax summary previously failed to clarify that the first >>> argument is also optional. The textual description did mention it, >>> but all the way at the bottom. It fits better with the command >>> overview, so move it there, and fix the summary also. >> >> Is it better to back-patch this to 9.4? The first argument of >> \pset command is optional also in 9.4. > > I didn't feel it necessary, but if you want to, it's OK with me. Yes, I'm inclined to back-patch that. Because the current description of the syntax of \pset in 9.4 is not correct. >> This commit is in next CF with "Ready for Committer". >> Probably it needs to be marked as "Committed". > > Done. Thanks. Regards, -- Fujii Masao
On Mon, Aug 11, 2014 at 12:14 PM, Fujii Masao <masao.fujii@gmail.com> wrote: > On Mon, Aug 11, 2014 at 6:34 AM, Robert Haas <robertmhaas@gmail.com> wrote: >> On Sun, Aug 10, 2014 at 12:55 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >>> On Thu, Jul 24, 2014 at 9:12 PM, Robert Haas <rhaas@postgresql.org> wrote: >>>> docs: Improve documentation of \pset without arguments. >>>> >>>> The syntax summary previously failed to clarify that the first >>>> argument is also optional. The textual description did mention it, >>>> but all the way at the bottom. It fits better with the command >>>> overview, so move it there, and fix the summary also. >>> >>> Is it better to back-patch this to 9.4? The first argument of >>> \pset command is optional also in 9.4. >> >> I didn't feel it necessary, but if you want to, it's OK with me. > > Yes, I'm inclined to back-patch that. Because the current description > of the syntax of \pset in 9.4 is not correct. Done. Regards, -- Fujii Masao