Обсуждение: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
Self review of previous patch. Fix assumption that xmax >= xmin. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=9975c683b102d06ed5d5ab799eaba0d00a9ff38c Modified Files -------------- src/backend/access/heap/heapam.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs <simon@2ndquadrant.com> wrote: > Self review of previous patch. Fix assumption that xmax >= xmin. This seems to require backporting. No? Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote: > On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs <simon@2ndquadrant.com> wrote: > > Self review of previous patch. Fix assumption that xmax >= xmin. > > This seems to require backporting. No? Already done. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services
Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
От
Heikki Linnakangas
Дата:
On 13.12.2010 14:56, Simon Riggs wrote: > On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote: >> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon@2ndquadrant.com> wrote: >>> Self review of previous patch. Fix assumption that xmax>= xmin. >> >> This seems to require backporting. No? > > Already done. Nope, that follow-on patch is not in REL9_0_STABLE. -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
On Mon, 2010-12-13 at 15:23 +0200, Heikki Linnakangas wrote: > On 13.12.2010 14:56, Simon Riggs wrote: > > On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote: > >> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon@2ndquadrant.com> wrote: > >>> Self review of previous patch. Fix assumption that xmax>= xmin. > >> > >> This seems to require backporting. No? > > > > Already done. > > Nope, that follow-on patch is not in REL9_0_STABLE. Yes, it is. The work was bundled together and the commit messages differ. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services
Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
От
Heikki Linnakangas
Дата:
On 13.12.2010 16:01, Simon Riggs wrote: > On Mon, 2010-12-13 at 15:23 +0200, Heikki Linnakangas wrote: >> On 13.12.2010 14:56, Simon Riggs wrote: >>> On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote: >>>> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon@2ndquadrant.com> wrote: >>>>> Self review of previous patch. Fix assumption that xmax>= xmin. >>>> >>>> This seems to require backporting. No? >>> >>> Already done. >> >> Nope, that follow-on patch is not in REL9_0_STABLE. > > Yes, it is. > > The work was bundled together and the commit messages differ. No, it's not. See for yourself: http://git.postgresql.org/gitweb?p=postgresql.git;a=blob;f=src/backend/access/heap/heapam.c;h=1c934007b2edbe97e548a7e84fe5802b6b8c5c98;hb=refs/heads/REL9_0_STABLE#l3812 -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
Re: pgsql: Self review of previous patch. Fix assumption that xmax >= xmin.
От
Heikki Linnakangas
Дата:
On 13.12.2010 16:10, Heikki Linnakangas wrote: > On 13.12.2010 16:01, Simon Riggs wrote: >> On Mon, 2010-12-13 at 15:23 +0200, Heikki Linnakangas wrote: >>> On 13.12.2010 14:56, Simon Riggs wrote: >>>> On Mon, 2010-12-13 at 17:02 +0900, Fujii Masao wrote: >>>>> On Thu, Dec 9, 2010 at 7:22 PM, Simon Riggs<simon@2ndquadrant.com> >>>>> wrote: >>>>>> Self review of previous patch. Fix assumption that xmax>= xmin. >>>>> >>>>> This seems to require backporting. No? >>>> >>>> Already done. >>> >>> Nope, that follow-on patch is not in REL9_0_STABLE. >> >> Yes, it is. >> >> The work was bundled together and the commit messages differ. > > No, it's not. See for yourself: > > http://git.postgresql.org/gitweb?p=postgresql.git;a=blob;f=src/backend/access/heap/heapam.c;h=1c934007b2edbe97e548a7e84fe5802b6b8c5c98;hb=refs/heads/REL9_0_STABLE#l3812 Sorry, I was wrong and you were right. Looks like I need to visit the optician... -- Heikki Linnakangas EnterpriseDB http://www.enterprisedb.com
On Mon, Dec 13, 2010 at 11:17 PM, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com> wrote: > Sorry, I was wrong and you were right. Looks like I need to visit the > optician... Well, me too... Sorry for the noise. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
On Tue, 2010-12-14 at 00:09 +0900, Fujii Masao wrote: > On Mon, Dec 13, 2010 at 11:17 PM, Heikki Linnakangas > <heikki.linnakangas@enterprisedb.com> wrote: > > Sorry, I was wrong and you were right. Looks like I need to visit the > > optician... > > Well, me too... Sorry for the noise. No problems, thanks for checking my work. -- Simon Riggs http://www.2ndQuadrant.com/books/ PostgreSQL Development, 24x7 Support, Training and Services