Обсуждение: pgsql: Properly lowercase identifiers, uppercase keywords, in doc

Поиск
Список
Период
Сортировка

pgsql: Properly lowercase identifiers, uppercase keywords, in doc

От
momjian@postgresql.org (Bruce Momjian)
Дата:
Log Message:
-----------
Properly lowercase identifiers, uppercase keywords, in doc examples

Modified Files:
--------------
    pgsql/doc/src/sgml:
        syntax.sgml (r1.150 -> r1.151)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/syntax.sgml?r1=1.150&r2=1.151)

Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc

От
Tom Lane
Дата:
momjian@postgresql.org (Bruce Momjian) writes:
> Log Message:
> -----------
> Properly lowercase identifiers, uppercase keywords, in doc examples

Bruce, did you do that with a blind sed script?  You totally destroyed
the point of these examples.  Kindly revert.

            regards, tom lane

Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc

От
Thom Brown
Дата:
On 11 August 2010 23:04, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
>> Log Message:
>> -----------
>> Properly lowercase identifiers, uppercase keywords, in doc examples
>
> Bruce, did you do that with a blind sed script?  You totally destroyed
> the point of these examples.  Kindly revert.
>

Whilst that change definitely needs reverting, I noticed the following
doesn't read well:

"Additionally, comments can occur in SQL input. They are not tokens,
they are effectively equivalent to whitespace.

For example, the following is (syntactically) valid SQL input:"

You'd expect an example with comments in after reading that, but there isn't.

Maybe that "Additionally..." bit should be moved beneath the "This is
a sequence..." paragraph?

--
Thom Brown
Registered Linux user: #516935

Re: pgsql: Properly lowercase identifiers, uppercase keywords, in doc

От
Bruce Momjian
Дата:
Tom Lane wrote:
> momjian@postgresql.org (Bruce Momjian) writes:
> > Log Message:
> > -----------
> > Properly lowercase identifiers, uppercase keywords, in doc examples
>
> Bruce, did you do that with a blind sed script?  You totally destroyed
> the point of these examples.  Kindly revert.

Oops, reverted.  I was looking in there for something else and was
surprised that such odd casing had gotten into our docs.

--
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +