Обсуждение: pgsql: Fix backpatching error in recent patch for ALTER USER f RESET ALL

Log Message:
-----------
Fix backpatching error in recent patch for ALTER USER f RESET ALL behavior.
The argument list for array_set() changed in 8.2 (in connection with allowing
nulls in arrays) but the newer argument list was used in the patches applied
to 8.1 and 8.0 branches.  The patch for 7.4 was OK though.  Per compiler
warnings.

Tags:
----
REL8_0_STABLE

Modified Files:
--------------
    pgsql/src/backend/utils/misc:
        guc.c (r1.252.4.10 -> r1.252.4.11)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c?r1=1.252.4.10&r2=1.252.4.11)

Tom Lane wrote:
> Log Message:
> -----------
> Fix backpatching error in recent patch for ALTER USER f RESET ALL behavior.
> The argument list for array_set() changed in 8.2 (in connection with allowing
> nulls in arrays) but the newer argument list was used in the patches applied
> to 8.1 and 8.0 branches.  The patch for 7.4 was OK though.  Per compiler
> warnings.

Weird.  I triple-checked each branch, so I'm not sure how I
missed this problem.  Sorry.

--
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Tom Lane wrote:
>> Fix backpatching error in recent patch for ALTER USER f RESET ALL behavior.

> Weird.  I triple-checked each branch, so I'm not sure how I
> missed this problem.  Sorry.

Probably the warnings were buried in all the other noise that a modern
compiler spits out about back branches :-(.  I only happened to notice
because I rebuilt the back branches on an ancient gcc version, where
these new warnings stood out like a sore thumb.

            regards, tom lane