Обсуждение: pgsql: Un-break pg_dump for the case of zero-column tables.

Поиск
Список
Период
Сортировка

pgsql: Un-break pg_dump for the case of zero-column tables.

От
tgl@postgresql.org (Tom Lane)
Дата:
Log Message:
-----------
Un-break pg_dump for the case of zero-column tables.

This was evidently broken by the CREATE TABLE OF TYPE patch.  It would have
been noticed if anyone had bothered to try dumping and restoring the
regression database ...

Modified Files:
--------------
    pgsql/src/bin/pg_dump:
        pg_dump.c (r1.573 -> r1.574)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c?r1=1.573&r2=1.574)

Re: pgsql: Un-break pg_dump for the case of zero-column tables.

От
Magnus Hagander
Дата:
2010/2/24 Tom Lane <tgl@postgresql.org>:
> Log Message:
> -----------
> Un-break pg_dump for the case of zero-column tables.
>
> This was evidently broken by the CREATE TABLE OF TYPE patch.  It would have
> been noticed if anyone had bothered to try dumping and restoring the
> regression database ...

Is there a point in doing that at the end of "make check"? Or as a
separate step on the buildfarm?

It would at least find problems that cause syntax errors or such
things when loading, even if we don't compare the full data?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/