Обсуждение: pgsql: Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a

Log Message:
-----------
Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a stopgap
measure to get the Windows buildfarm members working again.  I don't
know if it's worth exposing these as configurables, or exactly how to
do it in the MSVC build system ...

Modified Files:
--------------
    pgsql/src/include:
        pg_config.h.win32 (r1.51 -> r1.52)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/pg_config.h.win32?r1=1.51&r2=1.52)

Tom Lane wrote:
> Log Message:
> -----------
> Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a stopgap
> measure to get the Windows buildfarm members working again.  I don't
> know if it's worth exposing these as configurables, or exactly how to
> do it in the MSVC build system ...
>
>
>

see src/tools/msvc/Solution.pm

The options are picked up from config.pl (which is the equivalent of
configure invocation options) in the new() subroutine, and the config
files are written accordingly in the GenerateFiles() subroutine.

In general I'm in favor of keeping these as closely aligned as possible.

cheers

andrew

Andrew Dunstan <andrew@dunslane.net> writes:
>> Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a stopgap
>> measure to get the Windows buildfarm members working again.  I don't
>> know if it's worth exposing these as configurables, or exactly how to
>> do it in the MSVC build system ...

> see src/tools/msvc/Solution.pm

> The options are picked up from config.pl (which is the equivalent of
> configure invocation options) in the new() subroutine, and the config
> files are written accordingly in the GenerateFiles() subroutine.

> In general I'm in favor of keeping these as closely aligned as possible.

Go for it --- I'm not excited about adding stuff to platform-specific
code that I can't test.

            regards, tom lane

On Mon, Apr 21, 2008 at 4:52 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Go for it --- I'm not excited about adding stuff to platform-specific
> code that I can't test.

I'm sure we could sort you out with a Windows box if you like.

*ducks*

:-)


--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
> > Log Message:
> > -----------
> > Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
> > stopgap measure to get the Windows buildfarm members working
> > again.  I don't know if it's worth exposing these as configurables,
> > or exactly how to do it in the MSVC build system ...
> >
> >
> >
>
> see src/tools/msvc/Solution.pm
>
> The options are picked up from config.pl (which is the equivalent of
> configure invocation options) in the new() subroutine, and the config
> files are written accordingly in the GenerateFiles() subroutine.
>
> In general I'm in favor of keeping these as closely aligned as
> possible.

Agreed. If it's a configurable option in the autoconf system, it should
be in the msvc one. I'll see if I can get this done during the day
today before you guys wake up again ;-)

//Magnus

Magnus Hagander wrote:
> Andrew Dunstan wrote:
> >
> >
> > Tom Lane wrote:
> > > Log Message:
> > > -----------
> > > Add FLOAT4PASSBYVAL/FLOAT8PASSBYVAL to pg_config.h.win32, as a
> > > stopgap measure to get the Windows buildfarm members working
> > > again.  I don't know if it's worth exposing these as
> > > configurables, or exactly how to do it in the MSVC build
> > > system ...
> > >
> > >
> > >
> >
> > see src/tools/msvc/Solution.pm
> >
> > The options are picked up from config.pl (which is the equivalent
> > of configure invocation options) in the new() subroutine, and the
> > config files are written accordingly in the GenerateFiles()
> > subroutine.
> >
> > In general I'm in favor of keeping these as closely aligned as
> > possible.
>
> Agreed. If it's a configurable option in the autoconf system, it
> should be in the msvc one. I'll see if I can get this done during the
> day today before you guys wake up again ;-)

Done.

//Magnus