Обсуждение: pgsql: Fix a portability bug (ye olde not casting a argument

Log Message:
-----------
Fix a portability bug (ye olde not casting a <ctype.h> argument to
unsigned char).  Fortunately we still have buildfarm machines that
will flag this.  Seems to be new in CVS HEAD, so no backpatch.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        cash.c (r1.70 -> r1.71)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/cash.c.diff?r1=1.70&r2=1.71)

"Tom Lane" <tgl@postgresql.org> writes:

> Log Message:
> -----------
> Fix a portability bug (ye olde not casting a <ctype.h> argument to
> unsigned char).  Fortunately we still have buildfarm machines that
> will flag this.  Seems to be new in CVS HEAD, so no backpatch.

Should we add buildfarm animals which compile with -fsigned-chars and
-funsigned-chars in addition to the per-architecture defaults? Does that
guarantee that we'll trigger this warning or does it not help?

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

Gregory Stark <stark@enterprisedb.com> writes:
> "Tom Lane" <tgl@postgresql.org> writes:
>> Fix a portability bug (ye olde not casting a <ctype.h> argument to
>> unsigned char).  Fortunately we still have buildfarm machines that
>> will flag this.  Seems to be new in CVS HEAD, so no backpatch.

> Should we add buildfarm animals which compile with -fsigned-chars and
> -funsigned-chars in addition to the per-architecture defaults? Does that
> guarantee that we'll trigger this warning or does it not help?

Wouldn't help AFAICS.

            regards, tom lane