Обсуждение: pgsql: pg_stop_backup was calling XLogArchiveNotify() twice for the

Log Message:
-----------
pg_stop_backup was calling XLogArchiveNotify() twice for the newly created
backup history file.  Bug introduced by the 8.1 change to make pg_stop_backup
delete older history files.  Per report from Masao Fujii.

Tags:
----
REL8_1_STABLE

Modified Files:
--------------
    pgsql/src/backend/access/transam:
        xlog.c (r1.222.2.3 -> r1.222.2.4)

(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c.diff?r1=1.222.2.3&r2=1.222.2.4)

On Thu, 2006-06-22 at 17:43 -0300, Tom Lane wrote:
> Log Message:
> -----------
> pg_stop_backup was calling XLogArchiveNotify() twice for the newly created
> backup history file.  Bug introduced by the 8.1 change to make pg_stop_backup
> delete older history files.  Per report from Masao Fujii.
>
> Tags:
> ----
> REL8_1_STABLE
>
> Modified Files:
> --------------
>     pgsql/src/backend/access/transam:
>         xlog.c (r1.222.2.3 -> r1.222.2.4)
>
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c.diff?r1=1.222.2.3&r2=1.222.2.4)


This doesn't seem to be mentioned in the 8.1.5 release notes, so people
would not be aware they should upgrade to fix this.

--
  Simon Riggs
  EnterpriseDB   http://www.enterprisedb.com

Simon Riggs wrote:
> On Thu, 2006-06-22 at 17:43 -0300, Tom Lane wrote:
> > Log Message:
> > -----------
> > pg_stop_backup was calling XLogArchiveNotify() twice for the newly created
> > backup history file.  Bug introduced by the 8.1 change to make pg_stop_backup
> > delete older history files.  Per report from Masao Fujii.
> >
> > Tags:
> > ----
> > REL8_1_STABLE
> >
> > Modified Files:
> > --------------
> >     pgsql/src/backend/access/transam:
> >         xlog.c (r1.222.2.3 -> r1.222.2.4)
> >
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c.diff?r1=1.222.2.3&r2=1.222.2.4)
>
>
> This doesn't seem to be mentioned in the 8.1.5 release notes, so people
> would not be aware they should upgrade to fix this.

We don't mention every fix for every minor release.  People should
upgrade anyway, as we state in the FAQ.  Is there a reason this item was
significant?

--
  Bruce Momjian   bruce@momjian.us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

On Tue, 2006-11-14 at 17:40 -0500, Bruce Momjian wrote:
> Simon Riggs wrote:
> > On Thu, 2006-06-22 at 17:43 -0300, Tom Lane wrote:
> > > Log Message:
> > > -----------
> > > pg_stop_backup was calling XLogArchiveNotify() twice for the newly created
> > > backup history file.  Bug introduced by the 8.1 change to make pg_stop_backup
> > > delete older history files.  Per report from Masao Fujii.
> > >
> > > Tags:
> > > ----
> > > REL8_1_STABLE
> > >
> > > Modified Files:
> > > --------------
> > >     pgsql/src/backend/access/transam:
> > >         xlog.c (r1.222.2.3 -> r1.222.2.4)
> > >
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/transam/xlog.c.diff?r1=1.222.2.3&r2=1.222.2.4)
> >
> >
> > This doesn't seem to be mentioned in the 8.1.5 release notes, so people
> > would not be aware they should upgrade to fix this.
>
> We don't mention every fix for every minor release.  People should
> upgrade anyway, as we state in the FAQ.  Is there a reason this item was
> significant?

archiving doesn't work without this fix, but there's no message to
indicate why not.

If we don't mention it in the release notes then it becomes an
unexplained bug, which then makes people lose confidence, since when
they report it nobody can explain the bug (as just happened on -admin).

--
  Simon Riggs
  EnterpriseDB   http://www.enterprisedb.com