Обсуждение: pgsql-server/contrib/dblink Makefile
CVSROOT: /cvsroot
Module name: pgsql-server
Changes by: tgl@postgresql.org 02/09/03 00:01:05
Modified files:
contrib/dblink : Makefile
Log message:
Clean out cruft left by nonstandard test procedure.
Tom Lane wrote: > CVSROOT: /cvsroot > Module name: pgsql-server > Changes by: tgl@postgresql.org 02/09/03 00:01:05 > > Modified files: > contrib/dblink : Makefile > > Log message: > Clean out cruft left by nonstandard test procedure. > I see what you did, and understand why, but it made me wonder if there is a more standard way of doing a test procedure for contrib. Should I be doing something differently? Joe
Joe Conway <mail@joeconway.com> writes:
> I see what you did, and understand why, but it made me wonder if there
> is a more standard way of doing a test procedure for contrib. Should I
> be doing something differently?
Well, there is a standardized infrastructure for running ordinary
regression tests in contrib, but I dunno if it's of any use for dblink.
I suppose you could test in a single database by invoking dblink to
connect back to the same database you're in, but that'd seem like a
pretty cheesy test :-(.
I was planning to object to the "-U postgres" flags in your test script;
don't those just make it harder for people who aren't running the stuff
as user postgres? The 'pwd' invocations seem pointless as well.
regards, tom lane
Tom Lane wrote: > I was planning to object to the "-U postgres" flags in your test script; > don't those just make it harder for people who aren't running the stuff > as user postgres? The 'pwd' invocations seem pointless as well. Yeah, I was having problems getting it to run at all (for a variety of reasons), and I'll readily admit to not being much of a bash-scripting guru. Once I got it to run and produce the result I was looking for I never looked back! I can clean those up during beta though, right? Any other comments on the library itself? I know you haven't had much free time in the last few days, but I'd love to get and incorporate any feedback I can before RC1. Thanks, Joe
> I see what you did, and understand why, but it made me wonder if there > is a more standard way of doing a test procedure for contrib. Should I > be doing something differently? Yep - check contrib/tsearch Chris
Joe Conway wrote: > Tom Lane wrote: > > I was planning to object to the "-U postgres" flags in your test script; > > don't those just make it harder for people who aren't running the stuff > > as user postgres? The 'pwd' invocations seem pointless as well. > > Yeah, I was having problems getting it to run at all (for a variety of > reasons), and I'll readily admit to not being much of a bash-scripting > guru. Once I got it to run and produce the result I was looking for I > never looked back! I can clean those up during beta though, right? Yes, because it is /contrib. -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
Christopher Kings-Lynne wrote: >>I see what you did, and understand why, but it made me wonder if there >>is a more standard way of doing a test procedure for contrib. Should I >>be doing something differently? > > Yep - check contrib/tsearch > I did: cd contrib/tsearch make make install make installcheck I get very odd results: [...] + count_ignored=0 + echo + '[' 1 -eq 1 ']' + msg=All 1 tests passed. + result=0 ++ echo ' All 1 tests passed. ' ++ sed s/./=/g + dashes====================== + echo ===================== ===================== + echo ' All 1 tests passed. ' All 1 tests passed. + echo ===================== ===================== + echo + '[' -s ./regression.diffs ']' + rm -f ./regression.diffs ./regression.out + exit 0 + exit + savestatus=0 + '[' -n '' ']' + rm -f /tmp/pg_regress.4294 + exit 0 I take it that means that the test passed, but am I doing something wrong to get these results? Joe
I've noticed this as well - someones's screwed the tests I think... Hmmm - there's all sorts of problems in contrib: chriskl@alpha:~/pgsql-head/contrib/tsearch$ make clean "../../src/Makefile.global", line 38: Missing dependency operator "../../src/Makefile.global", line 41: Need an operator "../../src/Makefile.global", line 45: Need an operator "../../src/Makefile.global", line 66: Need an operator "../../src/Makefile.global", line 67: Need an operator "../../src/Makefile.global", line 69: Need an operator "../../src/Makefile.global", line 70: Need an operator "../../src/Makefile.global", line 73: Need an operator "../../src/Makefile.global", line 74: Need an operator "../../src/Makefile.global", line 76: Need an operator "../../src/Makefile.global", line 77: Need an operator "../../src/Makefile.global", line 80: Need an operator "../../src/Makefile.global", line 81: Need an operator "../../src/Makefile.global", line 83: Need an operator "../../src/Makefile.global", line 84: Need an operator "../../src/Makefile.global", line 88: Need an operator "../../src/Makefile.global", line 89: Need an operator "../../src/Makefile.global", line 91: Need an operator "../../src/Makefile.global", line 92: Need an operator "../../src/Makefile.global", line 96: Need an operator "../../src/Makefile.global", line 97: Need an operator "../../src/Makefile.global", line 99: Need an operator "../../src/Makefile.global", line 100: Need an operator "../../src/Makefile.global", line 108: Need an operator "../../src/Makefile.global", line 109: Need an operator "../../src/Makefile.global", line 111: Need an operator "../../src/Makefile.global", line 112: Need an operator "../../src/Makefile.global", line 170: Need an operator "../../src/Makefile.global", line 172: Need an operator "../../src/Makefile.global", line 177: Missing dependency operator "../../src/Makefile.global", line 179: Need an operator "../../src/Makefile.global", line 184: Missing dependency operator "../../src/Makefile.global", line 186: Need an operator "../../src/Makefile.port", line 3: Need an operator "../../src/Makefile.port", line 7: Need an operator "../../src/Makefile.port", line 13: Need an operator "../../src/Makefile.port", line 15: Need an operator "../../src/Makefile.port", line 23: Need an operator "../../src/Makefile.global", line 288: Missing dependency operator "../../src/Makefile.global", line 290: Need an operator "../../src/Makefile.global", line 324: Need an operator "../../src/Makefile.global", line 326: Missing dependency operator "../../src/Makefile.global", line 328: Need an operator "../../src/Makefile.global", line 330: Missing dependency operator "../../src/Makefile.global", line 332: Need an operator "../../src/Makefile.global", line 334: Missing dependency operator "../../src/Makefile.global", line 336: Need an operator "../../src/Makefile.global", line 338: Need an operator "../../src/Makefile.global", line 341: Need an operator "../../src/Makefile.global", line 343: Need an operator "../../src/Makefile.global", line 346: Need an operator "../../src/Makefile.global", line 355: Missing dependency operator "../../src/Makefile.global", line 358: Need an operator "../../src/Makefile.global", line 434: Missing dependency operator "../../src/Makefile.global", line 436: Need an operator "../../src/Makefile.global", line 438: Need an operator "../../src/Makefile.global", line 440: Need an operator "../../src/Makefile.global", line 442: Need an operator "../../src/Makefile.global", line 449: Need an operator "../../src/Makefile.global", line 452: Need an operator "../../src/Makefile.global", line 453: Need an operator "../../src/Makefile.global", line 455: Need an operator "../../src/Makefile.global", line 456: Need an operator "../../src/Makefile.global", line 458: Missing dependency operator "../../src/Makefile.global", line 465: Need an operator "../../src/Makefile.global", line 467: Missing dependency operator "../../src/Makefile.global", line 473: Need an operator "../../src/Makefile.global", line 478: Need an operator "../../src/Makefile.global", line 487: Need an operator "../../src/Makefile.global", line 494: Missing dependency operator "../../src/Makefile.global", line 495: Missing dependency operator "/home/chriskl/pgsql-head/src/nls-global.mk", line 25: Could not find /home/chriskl/pgsql-head/contrib/tsearch/nls.mk "/home/chriskl/pgsql-head/src/nls-global.mk", line 29: Need an operator "/home/chriskl/pgsql-head/src/nls-global.mk", line 31: Need an operator "/home/chriskl/pgsql-head/src/nls-global.mk", line 33: Need an operator "/home/chriskl/pgsql-head/src/nls-global.mk", line 38: Need an operator "/home/chriskl/pgsql-head/src/nls-global.mk", line 40: Need an operator Error expanding embedded variable. Chris > -----Original Message----- > From: Joe Conway [mailto:mail@joeconway.com] > Sent: Wednesday, 4 September 2002 2:43 AM > To: Christopher Kings-Lynne > Cc: Tom Lane; pgsql-committers@postgresql.org > Subject: Re: [COMMITTERS] pgsql-server/contrib/dblink Makefile > > > Christopher Kings-Lynne wrote: > >>I see what you did, and understand why, but it made me wonder if there > >>is a more standard way of doing a test procedure for contrib. Should I > >>be doing something differently? > > > > Yep - check contrib/tsearch > > > > I did: > > cd contrib/tsearch > make > make install > make installcheck > > I get very odd results: > > [...] > + count_ignored=0 > + echo > > + '[' 1 -eq 1 ']' > + msg=All 1 tests passed. > + result=0 > ++ echo ' All 1 tests passed. ' > ++ sed s/./=/g > + dashes====================== > + echo ===================== > ===================== > + echo ' All 1 tests passed. ' > All 1 tests passed. > + echo ===================== > ===================== > + echo > > + '[' -s ./regression.diffs ']' > + rm -f ./regression.diffs ./regression.out > + exit 0 > + exit > + savestatus=0 > + '[' -n '' ']' > + rm -f /tmp/pg_regress.4294 > + exit 0 > > I take it that means that the test passed, but am I doing something > wrong to get these results? > > Joe > >
I just did 'gmake clean' in pgsql/contrib and it worked fine. Strange. --------------------------------------------------------------------------- Christopher Kings-Lynne wrote: > I've noticed this as well - someones's screwed the tests I think... > > Hmmm - there's all sorts of problems in contrib: > > chriskl@alpha:~/pgsql-head/contrib/tsearch$ make clean > "../../src/Makefile.global", line 38: Missing dependency operator > "../../src/Makefile.global", line 41: Need an operator > "../../src/Makefile.global", line 45: Need an operator > "../../src/Makefile.global", line 66: Need an operator > "../../src/Makefile.global", line 67: Need an operator > "../../src/Makefile.global", line 69: Need an operator > "../../src/Makefile.global", line 70: Need an operator > "../../src/Makefile.global", line 73: Need an operator > "../../src/Makefile.global", line 74: Need an operator > "../../src/Makefile.global", line 76: Need an operator > "../../src/Makefile.global", line 77: Need an operator > "../../src/Makefile.global", line 80: Need an operator > "../../src/Makefile.global", line 81: Need an operator > "../../src/Makefile.global", line 83: Need an operator > "../../src/Makefile.global", line 84: Need an operator > "../../src/Makefile.global", line 88: Need an operator > "../../src/Makefile.global", line 89: Need an operator > "../../src/Makefile.global", line 91: Need an operator > "../../src/Makefile.global", line 92: Need an operator > "../../src/Makefile.global", line 96: Need an operator > "../../src/Makefile.global", line 97: Need an operator > "../../src/Makefile.global", line 99: Need an operator > "../../src/Makefile.global", line 100: Need an operator > "../../src/Makefile.global", line 108: Need an operator > "../../src/Makefile.global", line 109: Need an operator > "../../src/Makefile.global", line 111: Need an operator > "../../src/Makefile.global", line 112: Need an operator > "../../src/Makefile.global", line 170: Need an operator > "../../src/Makefile.global", line 172: Need an operator > "../../src/Makefile.global", line 177: Missing dependency operator > "../../src/Makefile.global", line 179: Need an operator > "../../src/Makefile.global", line 184: Missing dependency operator > "../../src/Makefile.global", line 186: Need an operator > "../../src/Makefile.port", line 3: Need an operator > "../../src/Makefile.port", line 7: Need an operator > "../../src/Makefile.port", line 13: Need an operator > "../../src/Makefile.port", line 15: Need an operator > "../../src/Makefile.port", line 23: Need an operator > "../../src/Makefile.global", line 288: Missing dependency operator > "../../src/Makefile.global", line 290: Need an operator > "../../src/Makefile.global", line 324: Need an operator > "../../src/Makefile.global", line 326: Missing dependency operator > "../../src/Makefile.global", line 328: Need an operator > "../../src/Makefile.global", line 330: Missing dependency operator > "../../src/Makefile.global", line 332: Need an operator > "../../src/Makefile.global", line 334: Missing dependency operator > "../../src/Makefile.global", line 336: Need an operator > "../../src/Makefile.global", line 338: Need an operator > "../../src/Makefile.global", line 341: Need an operator > "../../src/Makefile.global", line 343: Need an operator > "../../src/Makefile.global", line 346: Need an operator > "../../src/Makefile.global", line 355: Missing dependency operator > "../../src/Makefile.global", line 358: Need an operator > "../../src/Makefile.global", line 434: Missing dependency operator > "../../src/Makefile.global", line 436: Need an operator > "../../src/Makefile.global", line 438: Need an operator > "../../src/Makefile.global", line 440: Need an operator > "../../src/Makefile.global", line 442: Need an operator > "../../src/Makefile.global", line 449: Need an operator > "../../src/Makefile.global", line 452: Need an operator > "../../src/Makefile.global", line 453: Need an operator > "../../src/Makefile.global", line 455: Need an operator > "../../src/Makefile.global", line 456: Need an operator > "../../src/Makefile.global", line 458: Missing dependency operator > "../../src/Makefile.global", line 465: Need an operator > "../../src/Makefile.global", line 467: Missing dependency operator > "../../src/Makefile.global", line 473: Need an operator > "../../src/Makefile.global", line 478: Need an operator > "../../src/Makefile.global", line 487: Need an operator > "../../src/Makefile.global", line 494: Missing dependency operator > "../../src/Makefile.global", line 495: Missing dependency operator > "/home/chriskl/pgsql-head/src/nls-global.mk", line 25: Could not find > /home/chriskl/pgsql-head/contrib/tsearch/nls.mk > "/home/chriskl/pgsql-head/src/nls-global.mk", line 29: Need an operator > "/home/chriskl/pgsql-head/src/nls-global.mk", line 31: Need an operator > "/home/chriskl/pgsql-head/src/nls-global.mk", line 33: Need an operator > "/home/chriskl/pgsql-head/src/nls-global.mk", line 38: Need an operator > "/home/chriskl/pgsql-head/src/nls-global.mk", line 40: Need an operator > Error expanding embedded variable. > > Chris > > > -----Original Message----- > > From: Joe Conway [mailto:mail@joeconway.com] > > Sent: Wednesday, 4 September 2002 2:43 AM > > To: Christopher Kings-Lynne > > Cc: Tom Lane; pgsql-committers@postgresql.org > > Subject: Re: [COMMITTERS] pgsql-server/contrib/dblink Makefile > > > > > > Christopher Kings-Lynne wrote: > > >>I see what you did, and understand why, but it made me wonder if there > > >>is a more standard way of doing a test procedure for contrib. Should I > > >>be doing something differently? > > > > > > Yep - check contrib/tsearch > > > > > > > I did: > > > > cd contrib/tsearch > > make > > make install > > make installcheck > > > > I get very odd results: > > > > [...] > > + count_ignored=0 > > + echo > > > > + '[' 1 -eq 1 ']' > > + msg=All 1 tests passed. > > + result=0 > > ++ echo ' All 1 tests passed. ' > > ++ sed s/./=/g > > + dashes====================== > > + echo ===================== > > ===================== > > + echo ' All 1 tests passed. ' > > All 1 tests passed. > > + echo ===================== > > ===================== > > + echo > > > > + '[' -s ./regression.diffs ']' > > + rm -f ./regression.diffs ./regression.out > > + exit 0 > > + exit > > + savestatus=0 > > + '[' -n '' ']' > > + rm -f /tmp/pg_regress.4294 > > + exit 0 > > > > I take it that means that the test passed, but am I doing something > > wrong to get these results? > > > > Joe > > > > > > > ---------------------------(end of broadcast)--------------------------- > TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org > -- Bruce Momjian | http://candle.pha.pa.us pgman@candle.pha.pa.us | (610) 359-1001 + If your life is a hard drive, | 13 Roberts Road + Christ can be your backup. | Newtown Square, Pennsylvania 19073
OK, I'm stupid - I was going 'make clean', not 'gmake clean'. Grrr.
However, the contrib installcheck script is still stuffed. It spams the
screen with heaps of garbage instead of nicely running the checks like it
did up to yesterday...you even get the pg_regress help screen!!!
chriskl@alpha:~/pgsql-head/contrib/tsearch$ gmake installcheck
gmake -C ../../src/test/regress pg_regress
gmake[1]: Entering directory `/home/chriskl/pgsql-head/src/test/regress'
gmake[1]: `pg_regress' is up to date.
gmake[1]: Leaving directory `/home/chriskl/pgsql-head/src/test/regress'
../../src/test/regress/pg_regress tsearch
+ basename ../../src/test/regress/pg_regress
+ me=pg_regress
+ : /tmp
+ TMPFILE=/tmp/pg_regress.8201
+ help=PostgreSQL regression test driver
Usage: pg_regress [options...] [extra tests...]
Options:
--debug turn on debug mode in programs that are run
--inputdir=DIR take input files from DIR (default `.')
--multibyte=ENCODING use ENCODING as the multibyte encoding, and
also run a test by the same name
--outputdir=DIR place output files in DIR (default `.')
--schedule=FILE use test ordering schedule from FILE
(may be used multiple times to concatenate)
--temp-install[=DIR] create a temporary installation (in DIR)
Options for `temp-install' mode:
--top-builddir=DIR (relative) path to top level build directory
Chris
> -----Original Message-----
> From: pgsql-committers-owner@postgresql.org
> [mailto:pgsql-committers-owner@postgresql.org]On Behalf Of Christopher
> Kings-Lynne
> Sent: Wednesday, 4 September 2002 11:13 AM
> To: Joe Conway
> Cc: Tom Lane; pgsql-committers@postgresql.org
> Subject: Re: [COMMITTERS] pgsql-server/contrib/dblink Makefile
>
>
> I've noticed this as well - someones's screwed the tests I think...
>
> Hmmm - there's all sorts of problems in contrib:
>
> chriskl@alpha:~/pgsql-head/contrib/tsearch$ make clean
> "../../src/Makefile.global", line 38: Missing dependency operator
> "../../src/Makefile.global", line 41: Need an operator
> "../../src/Makefile.global", line 45: Need an operator
> "../../src/Makefile.global", line 66: Need an operator
> "../../src/Makefile.global", line 67: Need an operator
> "../../src/Makefile.global", line 69: Need an operator
> "../../src/Makefile.global", line 70: Need an operator
> "../../src/Makefile.global", line 73: Need an operator
> "../../src/Makefile.global", line 74: Need an operator
> "../../src/Makefile.global", line 76: Need an operator
> "../../src/Makefile.global", line 77: Need an operator
> "../../src/Makefile.global", line 80: Need an operator
> "../../src/Makefile.global", line 81: Need an operator
> "../../src/Makefile.global", line 83: Need an operator
> "../../src/Makefile.global", line 84: Need an operator
> "../../src/Makefile.global", line 88: Need an operator
> "../../src/Makefile.global", line 89: Need an operator
> "../../src/Makefile.global", line 91: Need an operator
> "../../src/Makefile.global", line 92: Need an operator
> "../../src/Makefile.global", line 96: Need an operator
> "../../src/Makefile.global", line 97: Need an operator
> "../../src/Makefile.global", line 99: Need an operator
> "../../src/Makefile.global", line 100: Need an operator
> "../../src/Makefile.global", line 108: Need an operator
> "../../src/Makefile.global", line 109: Need an operator
> "../../src/Makefile.global", line 111: Need an operator
> "../../src/Makefile.global", line 112: Need an operator
> "../../src/Makefile.global", line 170: Need an operator
> "../../src/Makefile.global", line 172: Need an operator
> "../../src/Makefile.global", line 177: Missing dependency operator
> "../../src/Makefile.global", line 179: Need an operator
> "../../src/Makefile.global", line 184: Missing dependency operator
> "../../src/Makefile.global", line 186: Need an operator
> "../../src/Makefile.port", line 3: Need an operator
> "../../src/Makefile.port", line 7: Need an operator
> "../../src/Makefile.port", line 13: Need an operator
> "../../src/Makefile.port", line 15: Need an operator
> "../../src/Makefile.port", line 23: Need an operator
> "../../src/Makefile.global", line 288: Missing dependency operator
> "../../src/Makefile.global", line 290: Need an operator
> "../../src/Makefile.global", line 324: Need an operator
> "../../src/Makefile.global", line 326: Missing dependency operator
> "../../src/Makefile.global", line 328: Need an operator
> "../../src/Makefile.global", line 330: Missing dependency operator
> "../../src/Makefile.global", line 332: Need an operator
> "../../src/Makefile.global", line 334: Missing dependency operator
> "../../src/Makefile.global", line 336: Need an operator
> "../../src/Makefile.global", line 338: Need an operator
> "../../src/Makefile.global", line 341: Need an operator
> "../../src/Makefile.global", line 343: Need an operator
> "../../src/Makefile.global", line 346: Need an operator
> "../../src/Makefile.global", line 355: Missing dependency operator
> "../../src/Makefile.global", line 358: Need an operator
> "../../src/Makefile.global", line 434: Missing dependency operator
> "../../src/Makefile.global", line 436: Need an operator
> "../../src/Makefile.global", line 438: Need an operator
> "../../src/Makefile.global", line 440: Need an operator
> "../../src/Makefile.global", line 442: Need an operator
> "../../src/Makefile.global", line 449: Need an operator
> "../../src/Makefile.global", line 452: Need an operator
> "../../src/Makefile.global", line 453: Need an operator
> "../../src/Makefile.global", line 455: Need an operator
> "../../src/Makefile.global", line 456: Need an operator
> "../../src/Makefile.global", line 458: Missing dependency operator
> "../../src/Makefile.global", line 465: Need an operator
> "../../src/Makefile.global", line 467: Missing dependency operator
> "../../src/Makefile.global", line 473: Need an operator
> "../../src/Makefile.global", line 478: Need an operator
> "../../src/Makefile.global", line 487: Need an operator
> "../../src/Makefile.global", line 494: Missing dependency operator
> "../../src/Makefile.global", line 495: Missing dependency operator
> "/home/chriskl/pgsql-head/src/nls-global.mk", line 25: Could not find
> /home/chriskl/pgsql-head/contrib/tsearch/nls.mk
> "/home/chriskl/pgsql-head/src/nls-global.mk", line 29: Need an operator
> "/home/chriskl/pgsql-head/src/nls-global.mk", line 31: Need an operator
> "/home/chriskl/pgsql-head/src/nls-global.mk", line 33: Need an operator
> "/home/chriskl/pgsql-head/src/nls-global.mk", line 38: Need an operator
> "/home/chriskl/pgsql-head/src/nls-global.mk", line 40: Need an operator
> Error expanding embedded variable.
>
> Chris
>
> > -----Original Message-----
> > From: Joe Conway [mailto:mail@joeconway.com]
> > Sent: Wednesday, 4 September 2002 2:43 AM
> > To: Christopher Kings-Lynne
> > Cc: Tom Lane; pgsql-committers@postgresql.org
> > Subject: Re: [COMMITTERS] pgsql-server/contrib/dblink Makefile
> >
> >
> > Christopher Kings-Lynne wrote:
> > >>I see what you did, and understand why, but it made me wonder if there
> > >>is a more standard way of doing a test procedure for contrib. Should I
> > >>be doing something differently?
> > >
> > > Yep - check contrib/tsearch
> > >
> >
> > I did:
> >
> > cd contrib/tsearch
> > make
> > make install
> > make installcheck
> >
> > I get very odd results:
> >
> > [...]
> > + count_ignored=0
> > + echo
> >
> > + '[' 1 -eq 1 ']'
> > + msg=All 1 tests passed.
> > + result=0
> > ++ echo ' All 1 tests passed. '
> > ++ sed s/./=/g
> > + dashes======================
> > + echo =====================
> > =====================
> > + echo ' All 1 tests passed. '
> > All 1 tests passed.
> > + echo =====================
> > =====================
> > + echo
> >
> > + '[' -s ./regression.diffs ']'
> > + rm -f ./regression.diffs ./regression.out
> > + exit 0
> > + exit
> > + savestatus=0
> > + '[' -n '' ']'
> > + rm -f /tmp/pg_regress.4294
> > + exit 0
> >
> > I take it that means that the test passed, but am I doing something
> > wrong to get these results?
> >
> > Joe
> >
> >
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org
>