Обсуждение: tries to use -h switch when not needed
I have noticed that on Mac OS X (v 1.8.1) and Debian Etch (v 1.4.3), I see incorrect behavior when trying to restore into a database when the connection to the database is via a UNIX domain socket. In such a case, there is no hostname specified. However, the commandline produced for the restore command is this: /usr/bin/pg_restore -i -h -p 5432 -U roberto -d jilldb -v "/network/home/roberto/tmp/pg.backup" So, even though the configuration for the server in question lists neither hostname nor port number, it tries to add both to the command line. Since the port has a sensible default, it is at least given a value. The host, on the other hand, has no sensible default and so is left blank causing pg_restore to fail. Anyhow, it seems to me that the logic behind this should be made a little smarter such that if neither host nor port are specified that the corresponding command-line options should be omitted. Regards, -Roberto -- Roberto C. Sánchez http://people.connexer.com/~roberto http://www.connexer.com
On Wed, Mar 19, 2008 at 5:19 AM, Roberto C. Sánchez <roberto@connexer.com> wrote: > I have noticed that on Mac OS X (v 1.8.1) and Debian Etch (v 1.4.3), I > see incorrect behavior when trying to restore into a database when the > connection to the database is via a UNIX domain socket. In such a case, > there is no hostname specified. However, the commandline produced for > the restore command is this: > > /usr/bin/pg_restore -i -h -p 5432 -U roberto -d jilldb -v "/network/home/roberto/tmp/pg.backup" > > So, even though the configuration for the server in question lists > neither hostname nor port number, it tries to add both to the command > line. Since the port has a sensible default, it is at least given a > value. The host, on the other hand, has no sensible default and so is > left blank causing pg_restore to fail. Anyhow, it seems to me that the > logic behind this should be made a little smarter such that if neither > host nor port are specified that the corresponding command-line options > should be omitted. > I've committed changes to omit the -h option when it's not specified. We don't really support not specifying the port number, so I've left that as is. Thanks for the report. -- Dave Page EnterpriseDB UK Ltd: http://www.enterprisedb.com PostgreSQL UK 2008 Conference: http://www.postgresql.org.uk
On Wed, Mar 19, 2008 at 11:35:08AM +0000, Dave Page wrote: > > I've committed changes to omit the -h option when it's not specified. > We don't really support not specifying the port number, so I've left > that as is. > > Thanks for the report. > Thanks for fixing this so quickly. Regards, -Roberto -- Roberto C. Sánchez http://people.connexer.com/~roberto http://www.connexer.com