Обсуждение: Re: FW: pgAdmin3: adding comments to existing tables
> -----Original Message----- > From: Andreas Pflug [mailto:pgadmin@pse-consulting.de] > Sent: 16 July 2003 11:47 > To: Dave Page > Cc: pgadmin-support@postgresql.org > Subject: Re: FW: [pgadmin-support] pgAdmin3: adding comments > to existing tables > > > Dave Page wrote: > > >Hi Andreas, > > > >This is a little worrying - I just tried it here and when > trying to set > >a comment on a table, what it actually executed was: > > > >ALTER TABLE fig.test ADD COLUMN fooCol fig.foo_domain; > >ALTER TABLE fig.test ADD COLUMN myFatCol int4[]; > >ALTER TABLE fig.test DROP COLUMN "fooCol"; > >ALTER TABLE fig.test DROP COLUMN "myFatCol"; > > > OK, took quite a while until I understood what's going on. > qtIdent was > missing on the column name, and fooCol is not the same as "fooCol" so > the mechanism to determine if a column definition is already present > didn't hit. Looks OK now, though the definition pane needs a refresh to see the changes. > >Also, selecting a column and clicking Change does nothing. > > > Not implemented... OK.
Dave Page wrote: > > >Looks OK now, though the definition pane needs a refresh to see the >changes. > > What do you mean with "needs a refresh"? Every time the sql page is selected, the sql query is freshly assembled. Do you have a GUI refresh problem? Regards, Andreas
----- Original Message ----- From: "Andreas Pflug" <pgadmin@pse-consulting.de> To: "Dave Page" <dpage@vale-housing.co.uk> Cc: <pgadmin-support@postgresql.org> Sent: Wednesday, July 16, 2003 5:30 PM Subject: Re: FW: [pgadmin-support] pgAdmin3: adding comments to existing tables >> Dave Page wrote: >> > >> > >> >Looks OK now, though the definition pane needs a refresh to see the >> >changes. >> > >> > >> What do you mean with "needs a refresh"? Every time the sql page is >> selected, the sql query is freshly assembled. Do you have a GUI refresh >> problem? I think what he means is, according to the behaviour that I have also noticed, editing anything using the properties dialog on a table, view etc., the changes are not immediately seen in the tree view display after the update. You have to do a manual refresh on the item in the tree view to see the changes or select a different item in the tree view and then re-select the original item. Regards Donald Fraser.
Donald Fraser wrote: >----- Original Message ----- >From: "Andreas Pflug" <pgadmin@pse-consulting.de> >To: "Dave Page" <dpage@vale-housing.co.uk> >Cc: <pgadmin-support@postgresql.org> >Sent: Wednesday, July 16, 2003 5:30 PM >Subject: Re: FW: [pgadmin-support] pgAdmin3: adding comments to existing tables > > > > >>>Dave Page wrote: >>> >>> >>>>Looks OK now, though the definition pane needs a refresh to see the >>>>changes. >>>> >>>> >>>> >>>> >>>What do you mean with "needs a refresh"? Every time the sql page is >>>selected, the sql query is freshly assembled. Do you have a GUI refresh >>>problem? >>> >>> > >I think what he means is, according to the behaviour that I have also noticed, >editing anything using the properties dialog on a table, view etc., the changes >are not immediately seen in the tree view display after the update. >You have to do a manual refresh on the item in the tree view to see the changes >or select a different item in the tree view and then re-select the original >item. > > > Ah yes, *after* executing the change only the properties are refreshed, but not the reverse-engineered sql. I'll fix this. Regards, Andreas
It's rumoured that Andreas Pflug once said: > Dave Page wrote: > >> >> >>Looks OK now, though the definition pane needs a refresh to see the >>changes. >> >> > What do you mean with "needs a refresh"? Every time the sql page is > selected, the sql query is freshly assembled. Do you have a GUI refresh > problem? When you click OK, the definition in the main form doesn't update. It did when I was playing with a view earlier. Regards, Dave.
Dave Page wrote: >It's rumoured that Andreas Pflug once said: > > >>Dave Page wrote: >> >> >> >>>Looks OK now, though the definition pane needs a refresh to see the >>>changes. >>> >>> >>> >>> >>What do you mean with "needs a refresh"? Every time the sql page is >>selected, the sql query is freshly assembled. Do you have a GUI refresh >> problem? >> >> > >When you click OK, the definition in the main form doesn't update. It did >when I was playing with a view earlier. >Regards, Dave. > > > Fixed. It was caused by the weird behaviour of stc, which won't allow SetText if readOnly. Regards, Andreas