Обсуждение: PATCH: To fix salt generation in session.py
Вложения
Hi Murtuza,
Can you please test this patch for the same?
On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,Please hold on in this patch, Need additional changes.--Regards,On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,With latest pull session.py fails with below error with python3 because in python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', PFA patch to fix the issue.Issue:----------File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in signself.randval = ''.join(random.sample(string.lowercase+string.digits, 20))AttributeError: module 'string' has no attribute 'lowercase'--Regards,
Вложения
Hi,
Tested, I'm able to login now.
Thanks,
Murtuza
--
Regards,
On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
Hi Murtuza,Can you please test this patch for the same?On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,Please hold on in this patch, Need additional changes.--Regards,On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,With latest pull session.py fails with below error with python3 because in python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', PFA patch to fix the issue.Issue:----------File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in signself.randval = ''.join(random.sample(string.lowercase+string.digits, 20))AttributeError: module 'string' has no attribute 'lowercase'--Regards,
I've committed the patch.
Thanks for testing it.
On Mon, Jul 11, 2016 at 4:30 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:
Hi,Tested, I'm able to login now.Thanks,Murtuza--Regards,On Mon, Jul 11, 2016 at 4:05 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Murtuza,Can you please test this patch for the same?On Mon, Jul 11, 2016 at 12:44 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,Please hold on in this patch, Need additional changes.--Regards,On Mon, Jul 11, 2016 at 12:41 PM, Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com> wrote:Hi,With latest pull session.py fails with below error with python3 because in python3 strings 'lowercase' method has been renamed to 'ascii_lowercase', PFA patch to fix the issue.Issue:----------File "../pgadmin4/web/pgadmin/utils/session.py", line 59, in signself.randval = ''.join(random.sample(string.lowercase+string.digits, 20))AttributeError: module 'string' has no attribute 'lowercase'--Regards,