Обсуждение: [pgAdmin4][Patch]: RM#1432 - File Browser - File does not exist error

Hi,

I think we need more changes than just that;

- The path at the top should not be editable (it should be greyed in fact)

- The path at the top should only show the directory path. The
filename should never be appended.

- The CSS needs to be fixed so the filename textbox at the bottom is
never hidden (as it is now if the dialogue opens at a small size).

- Double-click to navigate vs. rename should be modified to work in
part like it does on Mac - Double-click on either the icon or the name
should open the item (browser into a folder, or select and "OK" on a
file), and Click then Enter should rename. I'm hesitant to try to
implement "slow double click to rename" as that would likely need to
be tunable for accessibility reasons.

On Wed, Jul 6, 2016 at 10:42 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Hi
>
> Please find the patch with issue fixed:
> File Browser - File does not exist error
>>
>> it is due to wrong path formation. strip the leftmost slash only from the
>> file name selected not from the full path.
>
>
> Please review.
>
> Reply to the comments:
> The file browser is virtually unreadable (see screen shot), it does not work
> like Mac app
> It seems to be font issue to me. I will fix it and send a patch.
>
> When I click on the folder name, it offers to change the folder name instead
> of opening it (opening works when I click on the folder logo)
> we are performing two operations on double click:
> 1) Navigate inside the folder
> double clicking on folder icon allows to navigate inside the folder.
> 2) Rename folder
> double clicking on folder name allows to rename the file/folder.
>
> When I manage to navigate to the right file and want to open it, I get a red
> message ‘File does not exist’. That message disappears after 2-3 seconds
> attached a patch with fix.
>
> Thanks,
> Surinder Kumar
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> I think we need more changes than just that;
>>>
>>> - The path at the top should not be editable (it should be greyed in
>>> fact)
>>
>> Ok
>>>
>>>
>>> - The path at the top should only show the directory path. The
>>> filename should never be appended.
>>
>> Ok
>>>
>>>
>>> - The CSS needs to be fixed so the filename textbox at the bottom is
>>> never hidden (as it is now if the dialogue opens at a small size).
>>
>> Ok
>>>
>>>
>>> - Double-click to navigate vs. rename should be modified to work in
>>> part like it does on Mac - Double-click on either the icon or the name
>>> should open the item (browser into a folder, or select and "OK" on a
>>> file), and Click then Enter should rename. I'm hesitant to try to
>>> implement "slow double click to rename" as that would likely need to
>>> be tunable for accessibility reasons.
>>
>> Ok, I will fix it.
>
> In the current scenario, the Enter Key is bound to the OK button by default
> in Alertify dialog which servers the purpose of closing the dialog.
> Should we de-attach Enter Key event bound to OK button and use it for rename
> file?
> please suggest what should I do?

Hmm, good point.

How hard would it be to look for 2 consecutive single-clicks (but not
a double-click) for rename? If we can do that, it avoids timing
considerations for double-clicks (which would be defined by the OS).


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
>>
>> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
>> > <surinder.kumar@enterprisedb.com> wrote:
>> >>
>> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.org> wrote:
>> >>>
>> >>> Hi,
>> >>>
>> >>> I think we need more changes than just that;
>> >>>
>> >>> - The path at the top should not be editable (it should be greyed in
>> >>> fact)
>> >>
>> >> Ok
>> >>>
>> >>>
>> >>> - The path at the top should only show the directory path. The
>> >>> filename should never be appended.
>> >>
>> >> Ok
>> >>>
>> >>>
>> >>> - The CSS needs to be fixed so the filename textbox at the bottom is
>> >>> never hidden (as it is now if the dialogue opens at a small size).
>> >>
>> >> Ok
>> >>>
>> >>>
>> >>> - Double-click to navigate vs. rename should be modified to work in
>> >>> part like it does on Mac - Double-click on either the icon or the name
>> >>> should open the item (browser into a folder, or select and "OK" on a
>> >>> file), and Click then Enter should rename. I'm hesitant to try to
>> >>> implement "slow double click to rename" as that would likely need to
>> >>> be tunable for accessibility reasons.
>> >>
>> >> Ok, I will fix it.
>> >
>> > In the current scenario, the Enter Key is bound to the OK button by
>> > default
>> > in Alertify dialog which servers the purpose of closing the dialog.
>> > Should we de-attach Enter Key event bound to OK button and use it for
>> > rename
>> > file?
>> > please suggest what should I do?
>>
>> Hmm, good point.
>>
>> How hard would it be to look for 2 consecutive single-clicks (but not
>> a double-click) for rename? If we can do that, it avoids timing
>> considerations for double-clicks (which would be defined by the OS).
>
>
> I tried to implement slow double click, here is Fiddle
> There are two events 1) double click (it will be used for folder navigation)
> 2) Slow double click(For rename), It is a simple click event, when clicked
> twice after delay we consider it a slow double click.
>
> But it is not working smoothly, double click and single click events are
> conflicting.

Yeah, so I see.

> Also, we have rename button in navigation for rename operation,
> Can we skip slow double click because it is very confusing?

OK, I must have been having a brain failure moment or something. Yes,
skip it - we obviously don't need it with the rename button.

So we have:

- Click to select
- Double click to open a folder
- Button to rename the select file/folder

Sorry!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Thanks Surinder, patch applied.

I suspect the font rendering issue is related to others we've seen,
where the solution is to ensure the -webkit-transform CSS attribute is
set to none. Can you have a poke around with it please?

On Wed, Jul 13, 2016 at 2:58 PM, Surinder Kumar
<surinder.kumar@enterprisedb.com> wrote:
> Please find updated patch.
> This patch also includes the fix for issue  "File Browser - File does not
> exist error".
>
> On Wed, Jul 13, 2016 at 7:23 PM, Surinder Kumar
> <surinder.kumar@enterprisedb.com> wrote:
>>
>> I forgot to merge the fix for issue "File Browser - File does not exist
>> error" in the patch.
>> Please ignore this patch.
>>
>> On Wed, Jul 13, 2016 at 7:20 PM, Surinder Kumar
>> <surinder.kumar@enterprisedb.com> wrote:
>>>
>>> Please find updated patch with following changes/enhancements:
>>>
>>> Double click on file/folder icon or name will navigate to the
>>> folder/file.
>>> Selected file/folder can be renamed by Rename button only. Double click
>>> rename is removed.
>>> Filename text box will not hide on smaller screen. Setting minimum width
>>> of File Browser fixed it.
>>> Path at top will only show directory name, not the file name and it is
>>> greyed out.
>>>
>>> Issue not fixed:
>>> Icons and fonts of Query tool and File Browser looks blurred in Runtime
>>> environment.
>>> I tried debugging it. while debugging, It gets fixed on my ubuntu
>>> runtime. but I don't know how it gets fixed without changing css styles. It
>>> needs more time to debug.
>>>
>>> Please review.
>>>
>>> On Wed, Jul 13, 2016 at 5:15 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>>
>>>> On Tue, Jul 12, 2016 at 7:10 AM, Surinder Kumar
>>>> <surinder.kumar@enterprisedb.com> wrote:
>>>> > On Mon, Jul 11, 2016 at 6:41 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>> >>
>>>> >> On Thu, Jul 7, 2016 at 1:50 PM, Surinder Kumar
>>>> >> <surinder.kumar@enterprisedb.com> wrote:
>>>> >> > On Wed, Jul 6, 2016 at 7:02 PM, Surinder Kumar
>>>> >> > <surinder.kumar@enterprisedb.com> wrote:
>>>> >> >>
>>>> >> >> On Wed, Jul 6, 2016 at 5:40 PM, Dave Page <dpage@pgadmin.org>
>>>> >> >> wrote:
>>>> >> >>>
>>>> >> >>> Hi,
>>>> >> >>>
>>>> >> >>> I think we need more changes than just that;
>>>> >> >>>
>>>> >> >>> - The path at the top should not be editable (it should be greyed
>>>> >> >>> in
>>>> >> >>> fact)
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - The path at the top should only show the directory path. The
>>>> >> >>> filename should never be appended.
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - The CSS needs to be fixed so the filename textbox at the bottom
>>>> >> >>> is
>>>> >> >>> never hidden (as it is now if the dialogue opens at a small
>>>> >> >>> size).
>>>> >> >>
>>>> >> >> Ok
>>>> >> >>>
>>>> >> >>>
>>>> >> >>> - Double-click to navigate vs. rename should be modified to work
>>>> >> >>> in
>>>> >> >>> part like it does on Mac - Double-click on either the icon or the
>>>> >> >>> name
>>>> >> >>> should open the item (browser into a folder, or select and "OK"
>>>> >> >>> on a
>>>> >> >>> file), and Click then Enter should rename. I'm hesitant to try to
>>>> >> >>> implement "slow double click to rename" as that would likely need
>>>> >> >>> to
>>>> >> >>> be tunable for accessibility reasons.
>>>> >> >>
>>>> >> >> Ok, I will fix it.
>>>> >> >
>>>> >> > In the current scenario, the Enter Key is bound to the OK button by
>>>> >> > default
>>>> >> > in Alertify dialog which servers the purpose of closing the dialog.
>>>> >> > Should we de-attach Enter Key event bound to OK button and use it
>>>> >> > for
>>>> >> > rename
>>>> >> > file?
>>>> >> > please suggest what should I do?
>>>> >>
>>>> >> Hmm, good point.
>>>> >>
>>>> >> How hard would it be to look for 2 consecutive single-clicks (but not
>>>> >> a double-click) for rename? If we can do that, it avoids timing
>>>> >> considerations for double-clicks (which would be defined by the OS).
>>>> >
>>>> >
>>>> > I tried to implement slow double click, here is Fiddle
>>>> > There are two events 1) double click (it will be used for folder
>>>> > navigation)
>>>> > 2) Slow double click(For rename), It is a simple click event, when
>>>> > clicked
>>>> > twice after delay we consider it a slow double click.
>>>> >
>>>> > But it is not working smoothly, double click and single click events
>>>> > are
>>>> > conflicting.
>>>>
>>>> Yeah, so I see.
>>>>
>>>> > Also, we have rename button in navigation for rename operation,
>>>> > Can we skip slow double click because it is very confusing?
>>>>
>>>> OK, I must have been having a brain failure moment or something. Yes,
>>>> skip it - we obviously don't need it with the rename button.
>>>>
>>>> So we have:
>>>>
>>>> - Click to select
>>>> - Double click to open a folder
>>>> - Button to rename the select file/folder
>>>>
>>>> Sorry!
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>
>>>
>>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company