Обсуждение: PATCH: FTS Dictionary
Hi,
PFA patch for FTS Dictionaries.
Please do review it and let me know in case of any issues.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
Вложения
On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta <sanket.mehta@enterprisedb.com> wrote: > Hi, > > PFA patch for FTS Dictionaries. > Please do review it and let me know in case of any issues. Thanks - committed with a few cosmetic changes, and a couple of minor issues to resolve: 1) The template is not shown in properties views if it is not in a system schema (because of the way you are dealing with schema names etc). Please also check how the existing code will behave, if there is a template in the public schema with the same name as one in pg_catalog. 2) Please strip the quotes from the options before displaying them. I'll create a card for this. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Thanks for reviewing it Dave.
I will resolve these issues ASAP.
Regards,
Sanket Mehta
Sr Software engineer
Enterprisedb
On Fri, Apr 15, 2016 at 1:27 AM, Dave Page <dpage@pgadmin.org> wrote:
On Thu, Apr 14, 2016 at 3:41 PM, Sanket Mehta
<sanket.mehta@enterprisedb.com> wrote:
> Hi,
>
> PFA patch for FTS Dictionaries.
> Please do review it and let me know in case of any issues.
Thanks - committed with a few cosmetic changes, and a couple of minor
issues to resolve:
1) The template is not shown in properties views if it is not in a
system schema (because of the way you are dealing with schema names
etc). Please also check how the existing code will behave, if there is
a template in the public schema with the same name as one in
pg_catalog.
2) Please strip the quotes from the options before displaying them.
I'll create a card for this.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company