Обсуждение: Reduce delay in keypress (input) in Query Tool

Поиск
Список
Период
Сортировка

Reduce delay in keypress (input) in Query Tool

От
Dhiraj Chawla
Дата:
Hi Dave,

It has been noticed that on certain systems, that typing into the Query Tool is extremely slow and characters get printed very slowly. The probable reason behind this is on each key press in Query Tool OnChangeStc() gets called in frmQuery which in turn calls updateMenu(). In updateMenu() we call the canSaveAsImage(), which internally updates the ModelSize of GQB with the updateModelSize() function.

Attached is the patch that fixes this issue by disabling the call to canSaveAsImage() when called updateMenu() is called from OnChangeStc(). In this way the model size of GQB won't get updated on press of each key.

Let me know views/thoughts on the same.

Thanks,

--
regards,

Dhiraj Chawla
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522

Вложения

Re: Reduce delay in keypress (input) in Query Tool

От
Dave Page
Дата:
Thanks, patch applied.

On Mon, Nov 5, 2012 at 2:38 PM, Dhiraj Chawla
<dhiraj.chawla@enterprisedb.com> wrote:
> Hi Dave,
>
> It has been noticed that on certain systems, that typing into the Query Tool
> is extremely slow and characters get printed very slowly. The probable
> reason behind this is on each key press in Query Tool OnChangeStc() gets
> called in frmQuery which in turn calls updateMenu(). In updateMenu() we call
> the canSaveAsImage(), which internally updates the ModelSize of GQB with the
> updateModelSize() function.
>
> Attached is the patch that fixes this issue by disabling the call to
> canSaveAsImage() when called updateMenu() is called from OnChangeStc(). In
> this way the model size of GQB won't get updated on press of each key.
>
> Let me know views/thoughts on the same.
>
> Thanks,
>
> --
> regards,
>
> Dhiraj Chawla
> Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
> Phone: +91-20-30589522
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Re: Reduce delay in keypress (input) in Query Tool

От
Dhiraj Chawla
Дата:
Thanks Dave.

On Thu, Nov 8, 2012 at 8:51 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Mon, Nov 5, 2012 at 2:38 PM, Dhiraj Chawla
<dhiraj.chawla@enterprisedb.com> wrote:
> Hi Dave,
>
> It has been noticed that on certain systems, that typing into the Query Tool
> is extremely slow and characters get printed very slowly. The probable
> reason behind this is on each key press in Query Tool OnChangeStc() gets
> called in frmQuery which in turn calls updateMenu(). In updateMenu() we call
> the canSaveAsImage(), which internally updates the ModelSize of GQB with the
> updateModelSize() function.
>
> Attached is the patch that fixes this issue by disabling the call to
> canSaveAsImage() when called updateMenu() is called from OnChangeStc(). In
> this way the model size of GQB won't get updated on press of each key.
>
> Let me know views/thoughts on the same.
>
> Thanks,
>
> --
> regards,
>
> Dhiraj Chawla
> Software Engineer
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
> Phone: +91-20-30589522
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
regards,

Dhiraj Chawla
Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

Phone: +91-20-30589522