Обсуждение: pgAdmin 1.15 experiences

Akshay; could you investigate please?

Thanks.

On Wed, Mar 14, 2012 at 3:00 PM, Wahlstedt Jyrki <jwa@wahlstedt.fi> wrote:

Hi,

I built the current pgAdmin from sources (i.e. fetch from git) with wxWidgets 2.9.3 on OS X 10.7.3 with the following configuration:

./configure --with-pgsql=/opt/local/lib/postgresql91 --with-wx=/opt/local --with-wx-version=2.9 --with-libxml2=/opt/local --with-libxslt=/opt/local --with-arch-x86_64 --enable-appbundle

Build goes fine, program starts, mostly ok, but connecting to a database requires a password like this:

Connection is formed, databases shown, objects also, then if I doubleclick a table name:

Click 'No' and:

click 'No', then crash with the following in the report:

Exception Type:  EXC_BAD_ACCESS (SIGSEGV)

Exception Codes: KERN_INVALID_ADDRESS at 0x00000000fffffff4

VM Regions Near 0xfffffff4:

--> shared memory          00000000ffff0000-00000000ffff2000 [    8K] r-x/r-x SM=SHM  

    

Application Specific Information:

objc[94776]: garbage collection is OFF

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread

0   libstdc++.6.dylib             0x9016da78 std::string::empty() const + 8

1   org.postgresql.pgadmin         0x005adabd 0x30000 + 5757629

2   org.postgresql.pgadmin         0x000a7065 0x30000 + 487525

3   org.postgresql.pgadmin         0x002908b5 0x30000 + 2492597

4   org.postgresql.pgadmin         0x00284082 0x30000 + 2441346

5   libwx_baseu-2.9.3.0.0.dylib   0x0199b23e wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const + 42

6   libwx_baseu-2.9.3.0.0.dylib   0x0199b281 wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const + 59

7   libwx_baseu-2.9.3.0.0.dylib   0x01abfbd6 wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) + 106

8   libwx_baseu-2.9.3.0.0.dylib   0x01ac1be5 wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) + 321

9   libwx_baseu-2.9.3.0.0.dylib   0x01ac2a2c wxEvtHandler::TryBeforeAndHere(wxEvent&) + 90

10  libwx_baseu-2.9.3.0.0.dylib   0x01ac1c65 wxEvtHandler::ProcessEventLocally(wxEvent&) + 27

11  libwx_baseu-2.9.3.0.0.dylib   0x01ac11df wxEvtHandler::ProcessEvent(wxEvent&) + 181

12  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b61da wxWindowBase::TryAfter(wxEvent&) + 148

13  libwx_baseu-2.9.3.0.0.dylib   0x01ac11fb wxEvtHandler::ProcessEvent(wxEvent&) + 209

14  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b61da wxWindowBase::TryAfter(wxEvent&) + 148

15  libwx_baseu-2.9.3.0.0.dylib   0x01ac11fb wxEvtHandler::ProcessEvent(wxEvent&) + 209

16  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b61da wxWindowBase::TryAfter(wxEvent&) + 148

17  libwx_baseu-2.9.3.0.0.dylib   0x01ac11fb wxEvtHandler::ProcessEvent(wxEvent&) + 209

18  libwx_baseu-2.9.3.0.0.dylib   0x01abfef0 wxEvtHandler::SafelyProcessEvent(wxEvent&) + 34

19  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b898b wxWindowBase::HandleWindowEvent(wxEvent&) const + 27

20  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015a8b4d wxTextEntryBase::SendTextUpdatedEvent(wxWindow*) + 133

21  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x01406fb1 wxTextEntry::WriteText(wxString const&) + 219

22  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015a8972 wxTextEntryBase::DoSetValue(wxString const&, int) + 78

23  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x01407c13 wxTextEntryBase::SetValue(wxString const&) + 35

24  org.postgresql.pgadmin         0x0023ba53 0x30000 + 2144851

25  org.postgresql.pgadmin         0x00296e0b 0x30000 + 2518539

26  org.postgresql.pgadmin         0x00237acf 0x30000 + 2128591

27  org.postgresql.pgadmin         0x002316b7 0x30000 + 2102967

28  org.postgresql.pgadmin         0x002f157e 0x30000 + 2889086

29  libwx_baseu-2.9.3.0.0.dylib   0x0199b23e wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const + 42

30  libwx_baseu-2.9.3.0.0.dylib   0x0199b281 wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const + 59

31  libwx_baseu-2.9.3.0.0.dylib   0x01abfbd6 wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) + 106

32  libwx_baseu-2.9.3.0.0.dylib   0x01ac1be5 wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) + 321

33  libwx_baseu-2.9.3.0.0.dylib   0x01ac2a2c wxEvtHandler::TryBeforeAndHere(wxEvent&) + 90

34  libwx_baseu-2.9.3.0.0.dylib   0x01ac11ce wxEvtHandler::ProcessEvent(wxEvent&) + 164

35  libwx_baseu-2.9.3.0.0.dylib   0x01ac1c84 wxEvtHandler::ProcessEventLocally(wxEvent&) + 58

36  libwx_baseu-2.9.3.0.0.dylib   0x01ac11df wxEvtHandler::ProcessEvent(wxEvent&) + 181

37  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b61da wxWindowBase::TryAfter(wxEvent&) + 148

38  libwx_baseu-2.9.3.0.0.dylib   0x01abfc3d wxEvtHandler::TryAfter(wxEvent&) + 31

39  libwx_baseu-2.9.3.0.0.dylib   0x01ac11fb wxEvtHandler::ProcessEvent(wxEvent&) + 209

40  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b61da wxWindowBase::TryAfter(wxEvent&) + 148

41  libwx_baseu-2.9.3.0.0.dylib   0x01ac11fb wxEvtHandler::ProcessEvent(wxEvent&) + 209

42  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x01609c92 wxScrollHelperEvtHandler::ProcessEvent(wxEvent&) + 46

43  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x0145d912 wxListMainWindow::SendNotify(unsigned long, int, wxPoint const&) + 192

44  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x01457dce wxListMainWindow::OnMouse(wxMouseEvent&) + 2300

45  libwx_baseu-2.9.3.0.0.dylib   0x0199b23e wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const + 42

46  libwx_baseu-2.9.3.0.0.dylib   0x0199b281 wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const + 59

47  libwx_baseu-2.9.3.0.0.dylib   0x01abfbd6 wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&) + 106

48  libwx_baseu-2.9.3.0.0.dylib   0x01ac1be5 wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*) + 321

49  libwx_baseu-2.9.3.0.0.dylib   0x01ac2a2c wxEvtHandler::TryBeforeAndHere(wxEvent&) + 90

50  libwx_baseu-2.9.3.0.0.dylib   0x01ac1c65 wxEvtHandler::ProcessEventLocally(wxEvent&) + 27

51  libwx_baseu-2.9.3.0.0.dylib   0x01ac11df wxEvtHandler::ProcessEvent(wxEvent&) + 181

52  libwx_baseu-2.9.3.0.0.dylib   0x01abfef0 wxEvtHandler::SafelyProcessEvent(wxEvent&) + 34

53  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x015b898b wxWindowBase::HandleWindowEvent(wxEvent&) const + 27

54  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x014b5f83 wxWidgetCocoaImpl::DoHandleMouseEvent(NSEvent*) + 121

55  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x014b6051 wxWidgetCocoaImpl::mouseEvent(NSEvent*, NSView*, void*) + 73

56  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x014bc958 wxOSX_mouseEvent(NSView*, objc_selector*, NSEvent*) + 88

57  com.apple.AppKit               0x931e0ca5 -[NSWindow sendEvent:] + 7533

58  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x0149af2a -[wxNSWindow sendEvent:] + 282

59  com.apple.AppKit               0x931790e7 -[NSApplication sendEvent:] + 4788

60  com.apple.AppKit               0x9310a6d5 -[NSApplication run] + 1007

61  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x014841d9 wxGUIEventLoop::DoRun() + 67

62  libwx_baseu-2.9.3.0.0.dylib   0x01a9abaa wxCFEventLoop::Run() + 144

63  libwx_baseu-2.9.3.0.0.dylib   0x0199bdbf wxAppConsoleBase::MainLoop() + 175

64  libwx_osx_cocoau_core-2.9.3.0.0.dylib 0x0141b034 wxApp::OnRun() + 30

65  libwx_baseu-2.9.3.0.0.dylib   0x01a177ae wxEntry(int&, wchar_t**) + 110

66  libwx_baseu-2.9.3.0.0.dylib   0x01a17872 wxEntry(int&, char**) + 50

67  org.postgresql.pgadmin         0x0005456e 0x30000 + 148846

68  org.postgresql.pgadmin         0x00038825 0x30000 + 34853

It's lovely to get finally rid of the Carbon era!

!

! Jyrki Wahlstedt

! http://www.wahlstedt.fi/jyrki/

!

! Our life is no dream; but it ought to become one and perhaps will.

! PGP key ID: 0x139CC386 fingerprint: F355 B46F 026C B8C1 89C0  A780 6366 EFD9 139C C386

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Hi 

I am able to reproduce the bug as per the steps given by Wahlstedt Jyrki. I have tried to fix the crash and it is working for me. Attached is the patch file. Please review it. If solution looks good then please commit the code.

On Wed, Mar 21, 2012 at 10:46 PM, Wahlstedt Jyrki <jwa@wahlstedt.fi> wrote:

On 15.3.2012, at 11.24, Akshay Joshi wrote:

On Wed, Mar 14, 2012 at 10:20 PM, Dave Page <dpage@pgadmin.org> wrote:

Akshay; could you investigate please?

   Not able to reproduce the bug on OSX 10.6.8 with Postgres 9.0. I don't have OSX version 10.7.3 

Hi,

I suppose I wasn't totally clear when showing how the crash occurred:

1) I opened pgAdmin (obviously), and connected to server, then clicked on 'Tables' in the left-hand pane.

2) Then I double-clicked a table name in the right-hand pane (like scoringsystem below).

3) Then crash (the window for the table is created, but is all grey)

This is just a check, I don't hope there is a crash, though it could make debugging easier…

with best greetings,

Jyrki Wahlstedt

--

Akshay Joshi
Senior Software Engineer 
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

On Wed, 2012-03-28 at 10:28 +0100, Dave Page wrote:
> That looks OK to me - thanks. Guillaume, what do you think (it's
> fixing a bug in your code :-) ). Basically the problem is in the code
> you added to prevent the same properties dialogue being opened twice,
> or dropping of objects that are open in dialogues. The issue was that
> the code always assumed the selected item in the treeview was the item
> on which it was acting, which is not always the case (for example, you
> might double-click an item in the listview).
>

It seems good to me. I don't reproduce the bug, so I can't say if this
specific patch fixed it. But the patch seems good.

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com