Обсуждение: pgAdmin III: erroneous references to "proargdefvals" attribute

Поиск
Список
Период
Сортировка

pgAdmin III: erroneous references to "proargdefvals" attribute

От
Nikhil S
Дата:
Hi,

The pgAdmin source base is peppered with references to a non-existent "proargdefvals" attribute. The FEATURE_FUNCTION_DEFAULTS feature will not get set because of this ever. This patch replaces the references to this attribute by the valid "proargdefaults" attribute.

Regards,
Nikhils
Вложения

Re: pgAdmin III: erroneous references to "proargdefvals" attribute

От
Nikhil S
Дата:
Hi,
 
The pgAdmin source base is peppered with references to a non-existent "proargdefvals" attribute.

Ok, this was being used in AS83, so we cannot remove these references completely.
 
The FEATURE_FUNCTION_DEFAULTS feature will not get set because of this ever. This patch replaces the references to this attribute by the valid "proargdefaults" attribute.


PFA, a revised patch which now checks for version number apropriately. The problem seems to be only with procedures/functions belonging to packages in the code.
 
Regards,
Nikhils
Вложения

Re: pgAdmin III: erroneous references to "proargdefvals" attribute

От
Dave Page
Дата:
Thanks, applied.

On Thu, Apr 28, 2011 at 10:59 AM, Nikhil S <nixmisc@gmail.com> wrote:
> Hi,
>
>>
>> The pgAdmin source base is peppered with references to a non-existent
>> "proargdefvals" attribute.
>
> Ok, this was being used in AS83, so we cannot remove these references
> completely.
>
>>
>> The FEATURE_FUNCTION_DEFAULTS feature will not get set because of this
>> ever. This patch replaces the references to this attribute by the valid
>> "proargdefaults" attribute.
>>
>
> PFA, a revised patch which now checks for version number apropriately. The
> problem seems to be only with procedures/functions belonging to packages in
> the code.
>
> Regards,
> Nikhils
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: pgAdmin III: erroneous references to "proargdefvals" attribute

От
Nikhil S
Дата:
Thanks Dave.

Regards,
Nikhils

On Thu, Apr 28, 2011 at 6:58 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

On Thu, Apr 28, 2011 at 10:59 AM, Nikhil S <nixmisc@gmail.com> wrote:
> Hi,
>
>>
>> The pgAdmin source base is peppered with references to a non-existent
>> "proargdefvals" attribute.
>
> Ok, this was being used in AS83, so we cannot remove these references
> completely.
>
>>
>> The FEATURE_FUNCTION_DEFAULTS feature will not get set because of this
>> ever. This patch replaces the references to this attribute by the valid
>> "proargdefaults" attribute.
>>
>
> PFA, a revised patch which now checks for version number apropriately. The
> problem seems to be only with procedures/functions belonging to packages in
> the code.
>
> Regards,
> Nikhils
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company