Обсуждение: pgAdmin III commit: Handles the service connection parameter
Handles the service connection parameter This parameter is related to the pg_service.conf file. Implements ticket #310. Branch ------ master Details ------- http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=93bcef991663f387a55dae9512f3bea916858ca1 Modified Files -------------- CHANGELOG | 2 + pgadmin/db/pgConn.cpp | 22 +++++++++++--- pgadmin/dlg/dlgSelectConnection.cpp | 4 +- pgadmin/dlg/dlgServer.cpp | 25 +++++++++++---- pgadmin/frm/frmMain.cpp | 1 + pgadmin/frm/frmStatus.cpp | 6 ++- pgadmin/include/db/pgConn.h | 9 ++++- pgadmin/include/schema/pgServer.h | 12 ++++++- pgadmin/pgscript/pgsApplication.cpp | 2 +- pgadmin/schema/pgRole.cpp | 1 + pgadmin/schema/pgServer.cpp | 55 +++++++++++++++++++++++----------- pgadmin/ui/dlgServer.xrc | 18 +++++++++-- 12 files changed, 115 insertions(+), 42 deletions(-)
Hi Guillaume, This commit seems to touch an XRC file, but not xrcDialogs.cpp. Oversight? On Mon, Apr 11, 2011 at 6:39 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Handles the service connection parameter > > This parameter is related to the pg_service.conf file. > Implements ticket #310. > > Branch > ------ > master > > Details > ------- > http://git.postgresql.org/gitweb?p=pgadmin3.git;a=commitdiff;h=93bcef991663f387a55dae9512f3bea916858ca1 > > Modified Files > -------------- > CHANGELOG | 2 + > pgadmin/db/pgConn.cpp | 22 +++++++++++--- > pgadmin/dlg/dlgSelectConnection.cpp | 4 +- > pgadmin/dlg/dlgServer.cpp | 25 +++++++++++---- > pgadmin/frm/frmMain.cpp | 1 + > pgadmin/frm/frmStatus.cpp | 6 ++- > pgadmin/include/db/pgConn.h | 9 ++++- > pgadmin/include/schema/pgServer.h | 12 ++++++- > pgadmin/pgscript/pgsApplication.cpp | 2 +- > pgadmin/schema/pgRole.cpp | 1 + > pgadmin/schema/pgServer.cpp | 55 +++++++++++++++++++++++----------- > pgadmin/ui/dlgServer.xrc | 18 +++++++++-- > 12 files changed, 115 insertions(+), 42 deletions(-) > > > -- > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org) > To make changes to your subscription: > http://www.postgresql.org/mailpref/pgadmin-hackers > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 11/04/2011 19:45, Dave Page a écrit : > [...] > This commit seems to touch an XRC file, but not xrcDialogs.cpp. Oversight? > No. I still have to commit the patch for small screens support. It would be best (or at least I think so) to commit the xrcDialogs at the end with this patch. But, thanks for the heads-up. -- Guillaume http://www.postgresql.fr http://dalibo.com
On Mon, Apr 11, 2011 at 8:03 PM, Guillaume Lelarge <guillaume@lelarge.info> wrote: > Le 11/04/2011 19:45, Dave Page a écrit : >> [...] >> This commit seems to touch an XRC file, but not xrcDialogs.cpp. Oversight? >> > > No. I still have to commit the patch for small screens support. It would > be best (or at least I think so) to commit the xrcDialogs at the end > with this patch. It should really be updated with any commit that touches a dialogue, so that any checkout (in theory) will always work. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Le 11/04/2011 21:05, Dave Page a écrit : > On Mon, Apr 11, 2011 at 8:03 PM, Guillaume Lelarge > <guillaume@lelarge.info> wrote: >> Le 11/04/2011 19:45, Dave Page a écrit : >>> [...] >>> This commit seems to touch an XRC file, but not xrcDialogs.cpp. Oversight? >>> >> >> No. I still have to commit the patch for small screens support. It would >> be best (or at least I think so) to commit the xrcDialogs at the end >> with this patch. > > It should really be updated with any commit that touches a dialogue, > so that any checkout (in theory) will always work. > Hmmm, yeah. I didn't think about that issue. You're right. -- Guillaume http://www.postgresql.fr http://dalibo.com